Skip to content

Commit

Permalink
[gardening] Disable exception caused by missing core dumps on windows
Browse files Browse the repository at this point in the history
Issue #36469

Change-Id: I57d53d1ef02841e1f5c9f9993f896a8d20ee6f18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98670
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
  • Loading branch information
mkustermann authored and commit-bot@chromium.org committed Apr 4, 2019
1 parent 2a8117c commit a0e82ba
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tools/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,9 @@ def _report_missing_crashes(self, missing, throw=True):
"Existing files which *did not* match the pattern inside the search "
"directory are are:\n %s"
% (missing_as_string, self._search_dir, '\n '.join(other_files)))
if throw:
# TODO: Figure out why windows coredump generation does not work.
# See http://dartbug.com/36469
if throw and GuessOS() != 'win32':
raise Exception('Missing crash dumps for: %s' % missing_as_string)

def _get_file_name(self, file):
Expand Down

0 comments on commit a0e82ba

Please sign in to comment.