Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart:dom indexeddb transaction method signature does not match spec #1812

Closed
sethladd opened this issue Feb 23, 2012 · 9 comments
Closed

dart:dom indexeddb transaction method signature does not match spec #1812

sethladd opened this issue Feb 23, 2012 · 9 comments
Assignees
Labels
web-libraries Issues impacting dart:html, etc., libraries
Milestone

Comments

@sethladd
Copy link
Contributor

I should be able to do:

db.transaction([storeName]);

But lib/dom/generated/src/frog/IDBDatabase.dart has this signature:

_IDBTransactionJs transaction(String storeName, int mode) native;

Two problems:

First argument should be a List<String>.
Second argument should be optional.

(Technically, both arguments are optional: https://developer.mozilla.org/en/IndexedDB/IDBDatabase#transaction())

@rakudrama
Copy link
Member

The referenced link declares the first type to be anything

IDBTransaction transaction(
  in optional any storeNames,
  in optional unsigned short mode
) raises (IDBDatabaseException);

The WebKit IDL specifies the storeName(s) parameter as a list, array and string.

        [CallWith=ScriptExecutionContext] IDBTransaction transaction(in DOMStringList storeNames, in [Optional=DefaultIsUndefined] unsigned short mode)
            raises (IDBDatabaseException);
        [CallWith=ScriptExecutionContext] IDBTransaction transaction(in DOMString[] storeNames, in [Optional=DefaultIsUndefined] unsigned short mode)
            raises (IDBDatabaseException);
        [CallWith=ScriptExecutionContext] IDBTransaction transaction(in DOMString storeName, in [Optional=DefaultIsUndefined] unsigned short mode)
            raises (IDBDatabaseException);

It seems that this is being damaged somehow by merging.
It might be best that Dart supports only the List<String> variant.

@rakudrama
Copy link
Member

Marked this as being blocked by #1852.

@rakudrama
Copy link
Member

Marked this as being blocked by #1886.

@rakudrama
Copy link
Member

Removed Area-UI label.
Added Area-DOM label.

@rakudrama
Copy link
Member

Marked this as blocking #1310.
Marked this as being blocked by #1852, #1886.
Unmarked this as being blocked by #-1852, #-1886.

@vsmenon
Copy link
Member

vsmenon commented Jul 11, 2012

Added this to the M1 milestone.
Marked this as being blocked by #1852, #1886.
Unmarked this as being blocked by #1852, #1886.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Sep 5, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@rakudrama
Copy link
Member

Fixed at r8369.
The signature is now:

abstract class IDBDatabase implements EventTarget {
   ...
  /** @­domName IDBDatabase.transaction */
  IDBTransaction transaction(storeName_OR_storeNames, String mode);
}


Added Fixed label.

@sethladd sethladd added Type-Defect web-libraries Issues impacting dart:html, etc., libraries labels Oct 4, 2012
@sethladd sethladd added this to the M2 milestone Oct 4, 2012
copybara-service bot pushed a commit that referenced this issue Sep 20, 2021
…eivers

Fixes #47211

Much of this change is about decision-making based on the _type_ of the
function in a FunctionReference, or the receiver of that function, in the
case of prefixed identifiers or property access.

Previously, there was a rule that only direct references to functions
(top-level, local, and method) could be torn off and type-instantiated.
That rule has been reversed (#1812), so a lot of unraveling has to be
done here.

`e.call<...>` is now legal for _any_ generic function-typed expression
`e`, which certainly may be an expression without a staticElement.
Additionally, `e<...>` is now legal for _any_ generic function-typed
expression `e`.

Because we no longer resolve PropertyAccess piecemeal, we no longer
report UNDEFINED_IDENTIFIER or UNDEFINED_PREFIXED_ELEMENT etc before
deciding to check if a tearoff is being made on a function-typed
element. The unfortunate side-effect here is some redundant
error-reporting. :( I've left TODOs.

Change-Id: I62106332e39d528cbd7cdfa5ec831dc56b394b52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 9, 2022
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/4d7dc93..f2bb6e9):
  f2bb6e92  2022-12-07  Sam Rawlins  Bump to 6.1.4 (#3266)

fixnum (https://github.com/dart-lang/fixnum/compare/62916f2..e4f5e97):
  e4f5e97  2022-12-08  Michael Thomsen  Change IntegerDivisionByZeroException to UnsupportedError (#100)
  3bd726f  2022-12-08  Devon Carew  rev the sdk min to 2.19.0-0 (#99)

logging (https://github.com/dart-lang/logging/compare/f322480..0373ef8):
  0373ef8  2022-12-07  Mushaheed Syed  Add a check that throws if a logger name ends with '.' (#123)
  6d46d71  2022-12-06  Devon Carew  Create no-response.yml (#124)

protobuf (https://github.com/dart-lang/protobuf/compare/4f3e328..2706b53):
  2706b53  2022-12-07  Mahdi K. Fard  Add type to a method parameter (#782)
  a57c16a  2022-12-07  Mahdi K. Fard  Fix a typo (#781)

shelf (https://github.com/dart-lang/shelf/compare/1c21047..32e342d):
  32e342d  2022-12-08  István Soós  Prepare the release of shelf_router_generator (#316)
  06e2fe6  2022-12-08  Kevin Moore  shelf: drop non-null-safe tests (#317)
  98363fd  2022-12-06  Kevin Moore  lint: sort pub dependencies
  ad6af2a  2022-12-06  Kevin Moore  shelf_static: move RegExp creation out of every request

test (https://github.com/dart-lang/test/compare/4dceb87..73cd754):
  73cd7540  2022-12-07  Nate Bosch  Record the working directory for VM platform (#1804)
  e40274a6  2022-12-07  Nate Bosch  Restore mono_repo config (#1810)
  02d8764e  2022-12-07  Sigurd Meldgaard  Use Future for return type in runner `main()`. (#1809)
  3d6039b3  2022-12-05  Nate Bosch  Merge test selections by path (#1806)

webdev (https://github.com/dart-lang/webdev/compare/e39506e..3e2364e):
  3e2364e  2022-12-07  Elliott Brooks (she/her)  Add the Dart Debugger / Flutter Inspector panels in Chrome DevTools (#1812)
  c164231  2022-12-07  Elliott Brooks (she/her)  Small fix to the extension test (#1811)
  4bbb4d0  2022-12-06  Elliott Brooks (she/her)  Gracefully handle debugger disconnect events (#1808)
  d3892cf  2022-12-05  Elliott Brooks (she/her)  Refactor puppeteer tests to use `Worker` type (#1809)

Change-Id: I42033e849f40f209831cfb344247b24ad7731ff0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274580
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 12, 2022
Revisions updated by `dart tools/rev_sdk_deps.dart`.

intl (https://github.com/dart-lang/intl/compare/a127902..881e53e):
  881e53e  Fri Dec 9 08:01:26 2022 -0800  Copybara-Service  Merge pull request #346 from lukepighetti:patch-1
  e5ca40d  Fri Dec 9 07:00:14 2022 -0800  Copybara-Service  Merge pull request #453 from selcukguvel:doc-fix
  edbfc06  Fri Dec 9 15:34:30 2022 +0100  Moritz  Merge branch 'master' into patch-1
  b489fdd  Fri Dec 9 15:30:23 2022 +0100  Moritz  Merge branch 'master' into doc-fix
  60a0d8c  Fri Dec 9 04:17:04 2022 -0800  Googler  Internal change
  ef953fd  Mon Mar 7 16:30:31 2022 +0300  selcukguvel  Fix NumberFormat document readability issue - Show "var eurosInUSFormat = .." on a new line
  aa98b67  Tue Dec 29 15:31:53 2020 -0500  Luke Pighetti  Remove 7 year old unimplemented fields

test (https://github.com/dart-lang/test/compare/73cd754..09fb067):
  09fb0679  Thu Dec 8 14:52:33 2022 -0800  Jacob MacDonald  prep packages for publishing (#1814)
  c8ac4382  Thu Dec 8 14:07:05 2022 -0800  Jacob MacDonald  Prepare for Dart 3.0 api removals (#1812)

Change-Id: I9a7caed3165d3b65e96001aa029602a09355bce8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274542
Auto-Submit: Michael Thomsen <mit@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

4 participants