Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart:dom indexeddb idbdatabase.createObjectStore missing optional parameters #1810

Closed
sethladd opened this issue Feb 23, 2012 · 7 comments
Closed
Labels

Comments

@sethladd
Copy link
Member

@sethladd sethladd commented Feb 23, 2012

I should be able to create an object store like this:

db.createObjectStore("customers", { keyPath: "ssn" });

But the current interface looks like this:

_IDBObjectStoreJs createObjectStore(String name) native;

@sethladd

This comment has been minimized.

Copy link
Member Author

@sethladd sethladd commented Feb 23, 2012

Set owner to @rakudrama.

@rakudrama

This comment has been minimized.

Copy link
Member

@rakudrama rakudrama commented Feb 25, 2012

The WebKit IDL is:

        IDBObjectStore createObjectStore(in DOMString name, in [Optional] OptionsObject options)
            raises (IDBDatabaseException);

OptionsObject is not defined - that is why the second parameter is missing.
The object has two properties (others ignored):
keyPath - string
autoIncrement - boolean

One option is to make these named optional parameters:

db.createObjectStore("customers", keyPath: "ssn", autoIncrement: false);

If OptionsObject is translated to Map<String, Dynamic>, the call would be:

db.createObjectStore("customers", { "keyPath": "ssn" });

@rakudrama

This comment has been minimized.

Copy link
Member

@rakudrama rakudrama commented Apr 12, 2012

Removed Area-UI label.
Added Area-DOM label.

@rakudrama

This comment has been minimized.

Copy link
Member

@rakudrama rakudrama commented Jun 22, 2012

Marked this as blocking #1310.

@vsmenon

This comment has been minimized.

Copy link
Member

@vsmenon vsmenon commented Jul 11, 2012

The API is fixed. Need to verify whether it works.


Added this to the Later milestone.

@iposva-google

This comment has been minimized.

Copy link
Contributor

@iposva-google iposva-google commented Aug 13, 2012

Removed Area-DOM label.
Added Area-HTML label.

@rakudrama

This comment has been minimized.

Copy link
Member

@rakudrama rakudrama commented Oct 4, 2012

JJ - can you verify?
I believe it was fixed by r11202 + r11208
Thanks!


Set owner to jjinux...@google.com.
Added Fixed label.

@sethladd sethladd added this to the Later milestone Oct 4, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.