Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwanted UI introduced to editor (tailgating with ltk.ui) #2250

Closed
pq opened this issue Mar 21, 2012 · 4 comments
Closed

Unwanted UI introduced to editor (tailgating with ltk.ui) #2250

pq opened this issue Mar 21, 2012 · 4 comments
Assignees
@scheglov
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@pq
Copy link
Member

pq commented Mar 21, 2012

Net-net: a bunch of new plugins got added to the editor in support of refactoring and they in turn introduce some unwanted UI contributions (see attached). The suspect plugins are listed below.

2 issues:

  1. We need to remove the unwanted UI contribs.
  2. Adding the plugins was expedient but it's pretty contrary to our streamlined direction (recall we worked really hard to remove them!). If we want to rethink, that's cool but let's pop up and have the conversation.

 /branches/bleeding_edge/dart/third_party/eclipse/3.7.0/plugins/org.eclipse.ui.navigator_3.5.100.I20110524-0800.jar
 /branches/bleeding_edge/dart/third_party/eclipse/3.7.0/plugins/org.eclipse.ltk.ui.refactoring_3.6.0.v20110505-0800.jar
 /branches/bleeding_edge/dart/third_party/eclipse/3.7.0/plugins/org.eclipse.compare_3.5.200.I20110525-0800.jar
 /branches/bleeding_edge/dart/third_party/eclipse/3.7.0/plugins/org.eclipse.team.core_3.6.0.I20110525-0800.jar
 /branches/bleeding_edge/dart/third_party/eclipse/3.7.0/plugins/org.eclipse.team.ui_3.6.100.I20110525-0800.jar

Attachments:
[Screen Shot 2012-03-21 at 2.48.43 PM.png](https://storage.googleapis.com/google-code-attachments/dart/issue-2250/comment-0/Screen Shot 2012-03-21 at 2.48.43 PM.png) (12.74 KB)
[Screen Shot 2012-03-21 at 2.49.12 PM.png](https://storage.googleapis.com/google-code-attachments/dart/issue-2250/comment-0/Screen Shot 2012-03-21 at 2.49.12 PM.png) (18.90 KB)
@pq
Copy link
Member Author

pq commented Mar 22, 2012

Some more unwanted UI (due to an object contribution on IResources) in the search results view... (see attached).

Attachment:
[Screen Shot 2012-03-21 at 10.24.16 PM.png](https://storage.googleapis.com/google-code-attachments/dart/issue-2250/comment-1/Screen Shot 2012-03-21 at 10.24.16 PM.png) (27.33 KB)

@stevemessick
Copy link
Contributor

Current plan is to modify the ltk plugin to remove dependencies on some of the other new plugins, and remove them too. We'll still need to get rid of the Refactor menu since I think ltk adds that (not positive). We'll talk about it Monday if not resolved by then.

Unwanted UI elements can be eliminated via activities, as is done in /com.google.dart.tools.deploy/plugin.xml

Set owner to @scheglov.

@scheglov
Copy link
Contributor

https://chromiumcodereview.appspot.com/9826019

Added Started label.

@scheglov
Copy link
Contributor

https://code.google.com/p/dart/source/detail?r=5765

Added Fixed label.

@pq pq added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Mar 23, 2012
amanpro30 added a commit to amanpro30/sdk that referenced this issue Feb 21, 2020
@amanpro30
Reverted back line dart-lang#2250
2aec4b2 
Made the modification as suggested.
copybara-service bot pushed a commit that referenced this issue Oct 17, 2023
@devoncarew
[deps] rev file, http, native, sse, test, tools, webdev
78debcc 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

file (https://github.com/google/file.dart/compare/a18ad1c..7418131):
  7418131  2023-10-11  Parker Lougheed  Remove now unnecessary glob dependency override (#226)

http (https://github.com/dart-lang/http/compare/88ec75e..7240d0a):
  7240d0a  2023-10-11  Brian Quinlan  Remove obsolete pigeon-generated file (#1032)
  827f4fe  2023-10-10  Brian Quinlan  Prepare to release cronet 0.4.0 (#1031)

native (https://github.com/dart-lang/native/compare/22f4481..757f503):
  757f503  2023-10-16  Gabriel Terwesten  Use `Logger.detached` for test loggers (#158)

sse (https://github.com/dart-lang/sse/compare/e190744..37df57d):
  37df57d  2023-10-13  Kevin Moore  Enable and fix latest lints (#91)

test (https://github.com/dart-lang/test/compare/4341470..ba050ae):
  ba050ae2  2023-10-13  Nate Bosch  Move functions to non-deprecated library (#2120)
  96e1ed2d  2023-10-13  Nate Bosch  Remove unused href field from error report (#2118)
  ae7f30e9  2023-10-13  Nate Bosch  Make compiler optional in calls to currentPlatform (#2117)

tools (https://github.com/dart-lang/tools/compare/92c5c15..ddeccf6):
  ddeccf6  2023-10-10  Elias Yishak  Handling malformed log items in log file (#175)

webdev (https://github.com/dart-lang/webdev/compare/7c2c2d7..8d48d5e):
  8d48d5ea  2023-10-13  Ben Konyi  Bump package:vm_service to ^12.0.0 (#2248)
  9102b427  2023-10-13  Anna Gringauze  Add evaluation test to webdev to catch issues with runtime debugging API (#2250)
  63c7e728  2023-10-12  Elliott Brooks  Cider expects messages from a Chrome extension to be a JS object, not a string (#2249)
  a10bf10e  2023-10-11  Devon Carew  regenerate from the latest package:mono_repo (#2247)

Change-Id: I5c16c1387b613d1e6076579b26e6b64735097b7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330662
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @scheglov @stevemessick