Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bootstraping VM used to build observatory #24136

Closed
sigmundch opened this issue Aug 19, 2015 · 8 comments
Closed

update bootstraping VM used to build observatory #24136

sigmundch opened this issue Aug 19, 2015 · 8 comments
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.

Comments

@sigmundch
Copy link
Member

We should update the vm used to build observatory in build.py. I inadvertly broke the build because I started using null-aware operators in dart2js, which are not yet in the VM that is used in the bootstrap process.

@whesse @johnmccutchan

@sigmundch sigmundch added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Aug 19, 2015
@rmacnak-google
Copy link
Contributor

It's fairly old:

~/dart2/sdk/tools/testing/bin/linux$ dart --version
Dart VM version: 1.9.0-dev.10.13 (Mon Mar 23 06:45:57 2015) on "linux_ia32"

@sigmundch
Copy link
Member Author

I for now reverted the use of ?? here: https://codereview.chromium.org/1293533006

@whesse
Copy link
Contributor

whesse commented Aug 19, 2015

We are planning to update the SDK used to build really soon now. Just waiting for a cl to land, enabled us to use a complete, downloaded SDK for this.

@whesse
Copy link
Contributor

whesse commented Sep 1, 2015

CL https://codereview.chromium.org/1322753005/ , which fixes issue #24053 , downloads the new 1.12.0 stable release SDK for all platforms. We then need to switch the observatory build over to this.

@sigmundch
Copy link
Member Author

Awesome - does this mean that observatory will be built with the pub/dart2js from that downloaded SDK as well? or just using the repo versions of pub/dart2js with the downloaded VM?

If we have a choice, I'd prefer the former: that would make it easier to ensure we are using a consistent set of sdk tools when we build observatory.

@whesse
Copy link
Contributor

whesse commented Sep 1, 2015

Yes, that is the point of uploading the whole SDK. We will also use this
to run the test scripts.
On Sep 1, 2015 6:38 PM, "sigmundch" notifications@github.com wrote:

Awesome - does this mean that observatory will be built with the
pub/dart2js from that downloaded SDK as well? or just using the repo
versions of pub/dart2js with the downloaded VM?

If we have a choice, I'd prefer the former: that would make it easier to
ensure we are using a consistent set of sdk tools when we build observatory.


Reply to this email directly or view it on GitHub
#24136 (comment).

@whesse
Copy link
Contributor

whesse commented Sep 9, 2015

The uploaded SDK is now available to the bots. The observatory team should now switch the build to use it.

@whesse
Copy link
Contributor

whesse commented Sep 29, 2015

The observatory now uses the downloaded SDK, which is the stable version 1.12.0, to build observatory. If that doesn't work, it falls back to using the bootstrap binary to build observatory.

@whesse whesse closed this as completed Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
None yet
Development

No branches or pull requests

3 participants