Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mac Builders #26057

Closed
zanderso opened this issue Mar 22, 2016 · 7 comments
Closed

Update Mac Builders #26057

zanderso opened this issue Mar 22, 2016 · 7 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io

Comments

@zanderso
Copy link
Member

And reenable the test standalone/io/secure_server_client_certificate_test after.

/cc @iposva-google @whesse
@zanderso zanderso added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Mar 22, 2016
zanderso added a commit that referenced this issue Mar 22, 2016
@zanderso
Update status file
b81aa55 
related #26057

Review URL: https://codereview.chromium.org/1821203002 .
@mraleph
Copy link
Member

mraleph commented Apr 24, 2018

@zanderso is there something still to be done here?

Closing this as stale, but please reopen if something still needs to happen.

@mraleph mraleph closed this as completed Apr 24, 2018
@mraleph mraleph added closed-obsolete Closed as the reported issue is no longer relevant area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. and removed area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Apr 24, 2018
@mraleph mraleph removed the closed-obsolete Closed as the reported issue is no longer relevant label May 11, 2021
@mraleph
Copy link
Member

mraleph commented May 11, 2021

The test is actually failing on Mac.

@mraleph mraleph reopened this May 11, 2021
@mraleph
Copy link
Member

mraleph commented May 11, 2021

We have a PR on gRPC (grpc/grpc-dart#472) which can't land because client certificates handling is (seemingly?) broken on Mac. Unfortunately I can't figure out what exactly is wrong because Handshake exception one gets is extremely uninformative. /cc @aam

@aam
Copy link
Contributor

aam commented May 11, 2021

@mraleph were you able to reproduce the failure locally?

@mraleph
Copy link
Member

mraleph commented May 11, 2021

Here is what I get on my mac (10.15.7)

$ dart tests/standalone/io/secure_server_client_certificate_test.dart
unittest-suite-wait-for-done
Unhandled exception:
HandshakeException: Connection terminated during handshake

the same test passes on Linux.

@aam
Copy link
Contributor

aam commented May 11, 2021

Unfortunately it passes on my mac 11.3.1 at https://dart.googlesource.com/sdk/+/9a9e854515278b90437ea27063af64e5c3df05aa. It also seems to pass on buildbots.

@mraleph
Copy link
Member

mraleph commented May 12, 2021

Bummer. I guess we will have to wait and see what happens when we update the bots to 10.14 (or get those Apple Silicon bots which are running 11).

If I have some time I will try to instrument the VM to print more informative handshake message.

Lets close this for now then.

@mraleph mraleph closed this as completed May 12, 2021
dart-bot pushed a commit that referenced this issue May 12, 2021
@aam
[vm/ssl] Reenable client certificate tests.
c395e5f 
Fixes #26057

Change-Id: I172f7b8221f34d2bd16df324d96ad7a6ec88d54d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199301
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mraleph @aam @zanderso