Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a constructor for MessageChannel #26349

Closed
nex3 opened this issue Apr 27, 2016 · 4 comments
Closed

Add a constructor for MessageChannel #26349

nex3 opened this issue Apr 27, 2016 · 4 comments
Assignees
@terrylucas
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@nex3
Copy link
Member

nex3 commented Apr 27, 2016

The MessageChannel class doesn't have a constructor, despite the JS class having one. This makes it pretty much impossible to use.
@nex3 nex3 added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Apr 27, 2016
This was referenced Apr 27, 2016
Closed
Closed
@nex3 nex3 mentioned this issue Mar 7, 2017
Closed
@kevmoo kevmoo added the S1 high label Mar 11, 2017
@alan-knight
Copy link
Contributor

It looks like the reason it doesn't have a constructor is that the IDL is marked as CustomConstructor, even though there doesn't seem to be anything special about it. And we don't provide a custom constructor implementation. So I think providing one would fix that.

@alan-knight
Copy link
Contributor

https://codereview.chromium.org/2864053002

@kevmoo kevmoo assigned terrylucas and unassigned alan-knight Feb 9, 2018
@kevmoo
Copy link
Member

kevmoo commented Mar 18, 2018

See https://developer.mozilla.org/en-US/docs/Web/API/MessageChannel/MessageChannel

@kevmoo kevmoo added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Mar 26, 2018
@terrylucas
Copy link
Contributor

Fixed https://dart-review.googlesource.com/c/sdk/+/48381

dart-bot pushed a commit that referenced this issue Mar 27, 2018
@terrylucas
Update getClientRects, removed xtab, removed bogus entry in dom.json,
bc75856 
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.

Fixed all tests using query and queryAll.

Fixes #25664
Fixes #26349
Fixes #32323
Fixes #32659
Fixes #32675

R=kevmoo@google.com

Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
@nex3 nex3 mentioned this issue Sep 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrylucas terrylucas

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nex3 @kevmoo @terrylucas @alan-knight