Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies in pkg/analyzer and release #26711

Closed
3 tasks done
kevmoo opened this issue Jun 15, 2016 · 11 comments
Closed
3 tasks done

Update dependencies in pkg/analyzer and release #26711

kevmoo opened this issue Jun 15, 2016 · 11 comments
Assignees
@bwilkerson
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Milestone
1.19

Comments

@kevmoo
Copy link
Member

kevmoo commented Jun 15, 2016 •
edited
Loading

  • html (support 0.13.0)
  • package_config (support 1.0.0)
  • string_scanner (support 1.0.0)

Will have to update DEPS and changes analyzer_cli, etc

Many things that use pkg/analyzer are not getting the latest version of pkg/crypto, pkg/convert because the latest version has not been published
@kevmoo kevmoo added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable labels Jun 15, 2016
@devoncarew
Copy link
Member

+1. I notice version skew between the warnings reported by the latest dev sdk and that reported by the last published analyzer version (0.27.4-alpha.13).

@bwilkerson bwilkerson added the P2 A bug or feature request we're likely to work on label Jun 20, 2016
@kevmoo
Copy link
Member Author

kevmoo commented Jul 6, 2016

Ping? Not burning the world down, but it is causing some version skew across some important packages.

kevmoo added a commit that referenced this issue Jul 27, 2016
@kevmoo
Update dependency on pkg/package_compiler
17a2ddf 
For analysis_server, analyzer, analyzer_cli, compiler packages

Progress on #26711

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2172683002 .
@nex3
Copy link
Member

nex3 commented Jul 27, 2016

This is blocking dart-lang/test#414. We need to upgrade analyzer to get better parsing, but if we do so its constraints mean our other dependencies are no longer strong-mode clean 😕.

@nex3 nex3 mentioned this issue Jul 27, 2016
Closed
@nex3
Copy link
Member

nex3 commented Jul 27, 2016 •
edited
Loading

Also, it looks like analyzer 0.27.3 is incompatible with crypto 2.0.0 and web_socket_channel 1.0.4 for whatever reason.

@devoncarew
Copy link
Member

It looks like the source in the sdk repo supports the latest packages. A non-dev version of the analyzer package hasn't been published since April (and has the older crypto dep). I think the resolution here is to publish a new non-dev version.

/cc @bwilkerson

@kevmoo kevmoo added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Jul 28, 2016
@kevmoo kevmoo added this to the 1.19 milestone Jul 28, 2016
@mit-mit
Copy link
Member

mit-mit commented Aug 1, 2016

We should get this assigned to someone now that it's tagged P1. @bwilkerson who can work on this?

@bwilkerson
Copy link
Member

... who can work on this?

Anyone. It doesn't even need to be someone on the analyzer team.

I'm not sure, based on the comments, what all needs to be done. My best guess is that analyzer's pubspec needs to be updated to allow html 0.13.0 (because it's in the checklist) and that we need to publish a non-alpha version of analyzer. Is that sufficient? What are the criteria for success?

@bwilkerson bwilkerson self-assigned this Aug 1, 2016
@bwilkerson
Copy link
Member

The version constraints for html have been updated (https://codereview.chromium.org/2202573002/). Is there anything else needed before we publish a non-alpha version?

@bwilkerson
Copy link
Member

Version 0.27.4 of analyzer has now been published. Can someone please let me know whether this solves the problem.

@mit-mit
Copy link
Member

mit-mit commented Aug 1, 2016

@kevmoo, are we good?

@kevmoo
Copy link
Member Author

kevmoo commented Aug 4, 2016

We're good! Thanks!

@kevmoo kevmoo closed this as completed Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwilkerson bwilkerson

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
1.19
Development

No branches or pull requests
5 participants
@nex3 @kevmoo @devoncarew @bwilkerson @mit-mit