Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitChars() in frogsh fails to resolve and has improper implementation of _split("") #269

Closed
DartBot opened this issue Oct 31, 2011 · 4 comments

Comments

@DartBot
Copy link

DartBot commented Oct 31, 2011

This issue was originally filed by financeC...@gmail.com


What steps will reproduce the problem?
1.Follow instructions how to build frog from dart_bleeding/dart/frog/README.txt
2.Add following test to tests/

~/dart_bleeding/dart/frog$ cat > tests/splitHello.dart << EOF
main() {
print('hello world');
String v = "hello world";
print(v.split(""));
print(v.split(' ')[0]);
print(v.split(' ')[1]);
print(v.splitChars());
}
EOF

3.

What is the expected output?
adam@ubuntu:~/dart_bleeding/dart/frog$ ./frogsh tests/splitHello.dart
hello world
h,e,l,l,o, ,w,o,r,l,d
hello
world
h,e,l,l,o, ,w,o,r,l,d

What do you see instead?
/home/adam/dart_bleeding/dart/frog/lib/string_implementation.dart:76:12: warning: can not resolve _split
    return _split("");
           ^^^^^^
hello world
hello
world

node.js:134
        throw e; // process.nextTick error, or 'error' event on first tick
        ^
TypeError: Object hello world has no method 'splitChars'
    at main (evalmachine.<anonymous>:324:11)
    at evalmachine.<anonymous>:335:1
    at runCodeWithContext (/home/adam/dart_bleeding/dart/frog/frogsh:1909:12)
    at main (/home/adam/dart_bleeding/dart/frog/frogsh:15896:7)
    at Object.<anonymous> (/home/adam/dart_bleeding/dart/frog/frogsh:16037:1)
    at Module._compile (module.js:411:26)
    at Object..js (module.js:417:10)
    at Module.load (module.js:343:31)
    at Function._load (module.js:302:12)
    at Array.<anonymous> (module.js:430:10)

What version of the product are you using? On what operating system?

adam@ubuntu:~/dart_bleeding/dart/frog$ svn info
Path: .
URL: http://dart.googlecode.com/svn/experimental/frog
Repository Root: http://dart.googlecode.com/svn
Repository UUID: 260f80e4-7a28-3924-810f-c04153c831b5
Revision: 938
Node Kind: directory
Schedule: normal
Last Changed Author: ahe@google.com
Last Changed Rev: 938
Last Changed Date: 2011-10-30 09:24:14 -0700 (Sun, 30 Oct 2011)

adam@ubuntu:~/dart_bleeding/dart/frog$ uname -a
Linux ubuntu 2.6.38-11-generic #­50-Ubuntu SMP Mon Sep 12 21:18:14 UTC 2011 i686 i686 i386 GNU/Linux

Please provide any additional information below.
A larger bug may be that splitChars() cannot be resolved properly.

Replaced _split("") with spliit("") in /dart_bleeding/dart/frog/lib/string_implementation.dart and got the following error instead:
adam@ubuntu:
/dart_bleeding/dart/frog$ ./frogsh tests/splitHello.dart
hello world
h,e,l,l,o, ,w,o,r,l,d
hello
world

node.js:134
        throw e; // process.nextTick error, or 'error' event on first tick
        ^
TypeError: Object hello world has no method 'splitChars'
    at main (evalmachine.<anonymous>:325:11)
    at evalmachine.<anonymous>:327:1
    at runCodeWithContext (/home/adam/dart_bleeding/dart/frog/frogsh:1909:12)
    at main (/home/adam/dart_bleeding/dart/frog/frogsh:15896:7)
    at Object.<anonymous> (/home/adam/dart_bleeding/dart/frog/frogsh:16037:1)
    at Module._compile (module.js:411:26)
    at Object..js (module.js:417:10)
    at Module.load (module.js:343:31)
    at Function._load (module.js:302:12)
    at Array.<anonymous> (module.js:430:10)

@DartBot
Copy link
Author

DartBot commented Oct 31, 2011

This comment was originally written by @financecoding


Sorry for the section of "What do you see instead?" should look like this (i modified code and didnt update that paste):

What do you see instead?
/home/adam/dart_bleeding/dart/frog/lib/string_implementation.dart:76:12: warning: can not resolve _split
    return _split("");
           ^^^^^^

hello world
h,e,l,l,o, ,w,o,r,l,d
hello
world

node.js:134
        throw e; // process.nextTick error, or 'error' event on first tick
        ^
TypeError: Object hello world has no method 'splitChars'
    at main (evalmachine.<anonymous>:324:11)
    at evalmachine.<anonymous>:335:1
    at runCodeWithContext (/home/adam/dart_bleeding/dart/frog/frogsh:1909:12)
    at main (/home/adam/dart_bleeding/dart/frog/frogsh:15896:7)
    at Object.<anonymous> (/home/adam/dart_bleeding/dart/frog/frogsh:16037:1)
    at Module._compile (module.js:411:26)
    at Object..js (module.js:417:10)
    at Module.load (module.js:343:31)
    at Function._load (module.js:302:12)
    at Array.<anonymous> (module.js:430:10)

@DartBot
Copy link
Author

DartBot commented Oct 31, 2011

This comment was originally written by drfibonacci@google.com


Added Area-Frog, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Oct 31, 2011

This comment was originally written by jimhug@google.com


Set owner to jimhug@google.com.
Added Accepted label.

@DartBot
Copy link
Author

DartBot commented Oct 31, 2011

This comment was originally written by jimhug@google.com


Thanks for the clear and easy to reproduce bug report! This should be fixed now.


Added Fixed label.

copybara-service bot pushed a commit that referenced this issue Feb 6, 2023
…ev, boolean_selector_rev, browser_launcher_rev, characters_rev, cli_util_rev, clock_rev, collection_rev, convert_rev, crypto_rev, csslib_rev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/a23ea85..bd3ac85):
  bd3ac85  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#234)
  86dacb3  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#233)

async (https://github.com/dart-lang/async/compare/f700e9a..8deaa40):
  8deaa40  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#234)
  b28604f  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#233)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/b35c25e..1124692):
  1124692  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#67)
  1e57757  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#68)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/76881df..b1efcf7):
  b1efcf7  2023-02-02  Devon Carew  add a publishing workflow action to dart-lang/benchmark_harness (#81)
  4e0c4e8  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#83)
  010ea89  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#82)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/ba7d86b..16e6ad3):
  16e6ad3  2023-01-31  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#42)
  c8874cc  2023-01-31  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#43)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/f2f01e4..bc2dc4e):
  bc2dc4e  2023-01-31  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#38)
  00a57fa  2023-01-31  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#39)

characters (https://github.com/dart-lang/characters/compare/4526aa8..29f3a3e):
  29f3a3e  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#73)
  6516030  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#74)

cli_util (https://github.com/dart-lang/cli_util/compare/32bc077..fd38b5f):
  fd38b5f  2023-01-31  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#74)
  166fbac  2023-01-31  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#75)

clock (https://github.com/dart-lang/clock/compare/65e8a13..5abb481):
  5abb481  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#43)
  11b18ed  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#44)

collection (https://github.com/dart-lang/collection/compare/a566328..0d0e184):
  0d0e184  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#268)
  d0897af  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#269)

convert (https://github.com/dart-lang/convert/compare/20d136c..83886e3):
  83886e3  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#75)
  a522506  2023-01-31  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#74)

crypto (https://github.com/dart-lang/crypto/compare/f854f2f..03eb2c9):
  03eb2c9  2023-01-31  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#139)
  b6d6b33  2023-01-31  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#140)

csslib (https://github.com/dart-lang/csslib/compare/f33d632..e6c8308):
  e6c8308  2023-01-31  Devon Carew  fix the reported span for expressions (#167)
  a190358  2023-01-31  Devon Carew  add a repro for #136 (#160)
  fa3e221  2023-01-31  Devon Carew  correct the logic in isPredefinedName (#166)

Change-Id: I68bc236d4e0b5c31b5d629f2b89f82f56d30a28e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281260
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant