Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicks on linked class and method names don't open corresponding declarations on cpu profile table) #27116

Closed
scheglov opened this issue Aug 19, 2016 · 3 comments
Closed

Clicks on linked class and method names don't open corresponding declarations on cpu profile table) #27116

scheglov opened this issue Aug 19, 2016 · 3 comments
Assignees
@B3rn475
Labels
area-observatory

Comments

@scheglov
Copy link
Contributor

It used to work.
@johnmccutchan
Copy link
Contributor

@scheglov please provide more detail, I'm not sure what isn't working.

@scheglov
Copy link
Contributor Author

When I click on the underlined method name here:
image
I expect that a new page with the method code is open.
Instead nothing happens.

If I click in the right callers/callees tables, selection in the left table is changes to this method.

B3rn475 added a commit that referenced this issue Aug 24, 2016
@B3rn475
Converted Observatory cpu-profile-table element
44d2b85 
Fixes=#27116

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2273993002 .
@scheglov
Copy link
Contributor Author

There is a bug in this version - its Stack% is always the same as Execution%.
image

B3rn475 added a commit that referenced this issue Aug 24, 2016
@B3rn475
Fixed cpu-profile-table data visualization
b4cf35c 
Fixes=#27116

R=johnmccutchan@google.com
TBR=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2271083003 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@B3rn475 B3rn475

Labels
area-observatory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnmccutchan @scheglov @B3rn475