Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roll co19 tests in DEPS #27162

Closed
whesse opened this issue Aug 26, 2016 · 0 comments
Closed

roll co19 tests in DEPS #27162

whesse opened this issue Aug 26, 2016 · 0 comments
Assignees
@whesse
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task

Comments

@whesse
Copy link
Contributor

whesse commented Aug 26, 2016

There are fixes to co19 tests to handle catchable syntax errors, and soon a fix that will reduce use of mirrors, for the --fast-startup dart2js tests.

Update the pinned version of co19 in sdk/DEPS so we get these fixes.
@whesse whesse added P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Aug 26, 2016
@whesse whesse self-assigned this Aug 26, 2016
whesse added a commit that referenced this issue Aug 29, 2016
@whesse
Update co19 to revision d4767b4caea3c5828ad8e053cd051d44a59061af
a829cff 
BUG=#27162
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2289813002 .
whesse added a commit that referenced this issue Aug 29, 2016
@whesse
Revert "Update co19 to revision d4767b4caea3c5828ad8e053cd051d44a5906…
792997c 
…1af"

This reverts commit a829cff.
The co19 update often introduces many test failures, even after testing
locally and updating status files.  So we may revert the update, after
seeing which tests are failing on the buildbot, to do more updates on
the status files before landing again.

BUG=#27162
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2288593005 .
@whesse whesse closed this as completed Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whesse