Remove ignored type failures #27223

jmesserly · 2016-09-01T21:20:38Z

From @vsmenon on August 25, 2016 16:49

This was a temporary workaround until generic methods. We should eliminate this:

https://github.com/dart-lang/dev_compiler/blob/master/tool/input_sdk/private/ddc_runtime/operations.dart#L272

Copied from original issue: dart-archive/dev_compiler#630

jmesserly · 2016-09-01T21:21:02Z

CC @leafpetersen

vsmenon · 2017-01-24T22:53:44Z

Note, this is currently blocked on lack of typed angular templates. Related to #27255.

Run most tests without the whitelisting. See #27223 R=leafp@google.com Review-Url: https://codereview.chromium.org/2739863003 .

vsmenon · 2017-03-30T15:28:50Z

I'd start with Angular Dart apps. Possible source of type failures:

Handwritten code - which we should just fix.
SDK code - which still has type errors
Generated code from protobufs.
Generated code from ng2 templates.
Generated code from pageloader / mirrors.

At this point, we don't know where most ignored errors are coming from. Pageloader will only trigger problems in tests though.

I'll look into adding tests - these eventually supposed to *not* get ignored (see #27223) R=leafp@google.com Review-Url: https://codereview.chromium.org/2788933002 .

dgrove · 2017-05-12T23:21:59Z

@vsmenon is this targeted for 1.24?

vsmenon · 2017-05-13T00:19:28Z

No, good progress with angular this q. Still issues in Zone code.

matanlurey · 2017-05-13T17:12:21Z

Vijay let's get a breakdown of known issues and we can work on it this/next week.

…

On Fri, May 12, 2017, 5:19 PM vsmenon ***@***.***> wrote: No, good progress with angular this q. Still issues in Zone code. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#27223 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKQ7tc3xguI20Lbqp_pGtBdM9bsH9vRks5r5PcRgaJpZM4JzJMy> .

vsmenon · 2017-07-21T18:27:34Z

Note, this is now primarily blocked on #30225

jmesserly · 2017-09-25T19:23:27Z

internally this is also blocked by code that uses mirrors to populate Dart class fields, often in unsound ways that bypasses field type checks.

munificent · 2017-12-13T21:42:08Z

As we go through and fix existing code that has these failures, here's a bit of verbiage we can use in commit logs to let people know what's going on:

In strong mode, a generic type instantiated with dynamic is not a
subtype of all types. You can't pass a List<dynamic> to something
expecting, say, List<int>.

These errors are usually detected statically, and most of those have
been fixed. However, sometimes this becomes a runtime cast, as in:

    main() {
      // Store a List<dynamic> in a variable of type dynamic.
      dynamic d = [];
    
      // Implicit runtime downcast from dynamic to List<String>.
      List<String> s = d;
    }

In order to ease the migration to strong mode, DDC has been ignoring
these cast failures when they involve certain commonly used types. We
are now in the process of actively fixing those errors.

More context: https://github.com/dart-lang/sdk/issues/27223

In strong mode, a generic type instantiated with dynamic is not a subtype of all types. You can't pass a List<dynamic> to something expecting, say, List<int>. These errors are usually detected statically, and most of those have been fixed. However, sometimes this becomes a runtime cast, as in: main() { // Store a List<dynamic> in a variable of type dynamic. dynamic d = []; // Implicit runtime downcast from dynamic to List<String>. List<String> s = d; } In order to ease the migration to strong mode, DDC has been ignoring these cast failures when they involve certain commonly used types. We are now in the process of actively fixing those errors. More context: dart-lang/sdk#27223

Fix a couple of strong mode runtime cast errors. In strong mode, a generic type instantiated with dynamic is not a subtype of all types. You can't pass a List<dynamic> to something expecting, say, List<int>. These errors are usually detected statically, and most of those have been fixed. However, sometimes this becomes a runtime cast, as in: main() { // Store a List<dynamic> in a variable of type dynamic. dynamic d = []; // Implicit runtime downcast from dynamic to List<String>. List<String> s = d; } In order to ease the migration to strong mode, DDC has been ignoring these cast failures when they involve certain commonly used types. We are now in the process of actively fixing those errors. More context: dart-lang/sdk#27223

See: dart-lang/sdk#27223

In strong mode, a generic type instantiated with dynamic is not a subtype of all types. You can't pass a List<dynamic> to something expecting, say, List<int>. These errors are usually detected statically, and most of those have been fixed. However, sometimes this becomes a runtime cast, as in: main() { // Store a List<dynamic> in a variable of type dynamic. dynamic d = []; // Implicit runtime downcast from dynamic to List<String>. List<String> s = d; } In order to ease the migration to strong mode, DDC has been ignoring these cast failures when they involve certain commonly used types. We are now in the process of actively fixing those errors. More context: dart-lang/sdk#27223

* Fix runtime cast failures. In strong mode, a generic type instantiated with dynamic is not a subtype of all types. You can't pass a List<dynamic> to something expecting, say, List<int>. These errors are usually detected statically, and most of those have been fixed. However, sometimes this becomes a runtime cast, as in: main() { // Store a List<dynamic> in a variable of type dynamic. dynamic d = []; // Implicit runtime downcast from dynamic to List<String>. List<String> s = d; } In order to ease the migration to strong mode, DDC has been ignoring these cast failures when they involve certain commonly used types. We are now in the process of actively fixing those errors. More context: dart-lang/sdk#27223 * Update SDK constraints. * Use newer dev version of the SDK on Travis. * Bump minimum SDK constraint.

See #27223 Change-Id: I9689ce9a72597b3e5c945f9787f2de6c5e8c2074 Reviewed-on: https://dart-review.googlesource.com/54701 Commit-Queue: Vijay Menon <vsm@google.com> Reviewed-by: Bob Nystrom <rnystrom@google.com> Reviewed-by: Jenny Messerly <jmesserly@google.com>

See #27223 Change-Id: Ia23edc3700a8e0bb3d982be9b0bb36ad4522091d Reviewed-on: https://dart-review.googlesource.com/56033 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Vijay Menon <vsm@google.com>

natebosch · 2018-08-24T22:30:26Z

Are these still ignored in the external SDK?

vsmenon · 2018-08-24T22:32:58Z

Should not be, but the hook is still there for internal.

jmesserly added P1 A high priority bug; for example, a single project is unusable or has many test failures soundness labels Sep 1, 2016

jmesserly mentioned this issue Sep 1, 2016

Remove ignored type failures dart-archive/dev_compiler#630

Closed

jmesserly added the web-dev-compiler label Sep 1, 2016

vsmenon modified the milestone: 1.50 Jan 6, 2017

vsmenon added soundness and removed soundness labels Jan 6, 2017

vsmenon modified the milestone: 1.50 Jan 6, 2017

vsmenon added the status-blocked Blocked from making progress by another (referenced) issue label Jan 24, 2017

dgrove modified the milestones: 1.50, 1.23 Feb 14, 2017

vsmenon added a commit that referenced this issue Mar 9, 2017

Add option to suppress type-check whitelisting

402e025

Run most tests without the whitelisting. See #27223 R=leafp@google.com Review-Url: https://codereview.chromium.org/2739863003 .

vsmenon added a commit that referenced this issue Mar 9, 2017

Add option to suppress type-check whitelisting

da1f954

Run most tests without the whitelisting. See #27223 R=leafp@google.com Review-Url: https://codereview.chromium.org/2739863003 .

vsmenon assigned leafpetersen Mar 9, 2017

vsmenon modified the milestones: 1.24, 1.23 Mar 20, 2017

vsmenon added the dev-compiler-beta label Mar 24, 2017

vsmenon assigned jmesserly and unassigned leafpetersen Mar 30, 2017

vsmenon added a commit that referenced this issue Mar 31, 2017

Fix ignore on FutureOr

08f0857

I'll look into adding tests - these eventually supposed to *not* get ignored (see #27223) R=leafp@google.com Review-Url: https://codereview.chromium.org/2788933002 .

vsmenon added a commit that referenced this issue Mar 31, 2017

Fix ignore on FutureOr

1dc8ab7

I'll look into adding tests - these eventually supposed to *not* get ignored (see #27223) R=leafp@google.com Review-Url: https://codereview.chromium.org/2788933002 .

vsmenon modified the milestones: 1.25, 1.24 May 13, 2017

jmesserly removed their assignment Sep 25, 2017

vsmenon mentioned this issue Nov 16, 2017

DDC not memoizing ignored failures correctly #31392

Closed

munificent mentioned this issue Dec 13, 2017

Fix a couple of strong mode runtime cast errors. dart-lang/test#733

Merged

munificent self-assigned this Dec 21, 2017

munificent added a commit to dart-lang/stack_trace that referenced this issue Feb 14, 2018

Fix runtime cast failure in chainForTrace().

2513464

See: dart-lang/sdk#27223

munificent mentioned this issue Feb 14, 2018

Fix runtime cast failure in chainForTrace(). dart-lang/stack_trace#38

Merged

munificent mentioned this issue Mar 1, 2018

Fix runtime cast failures. google/observable#57

Merged

munificent mentioned this issue Mar 6, 2018

Fix runtime cast failure in JsObjectAsMap.keys. a14n/dart-js-wrapping#20

Merged

dgrove removed this from the 1.25 milestone Mar 20, 2018

jmesserly removed the dev-compiler-beta label Apr 19, 2018

vsmenon closed this as completed Jul 20, 2019

vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove ignored type failures #27223

Remove ignored type failures #27223

jmesserly commented Sep 1, 2016

jmesserly commented Sep 1, 2016

vsmenon commented Jan 24, 2017

vsmenon commented Mar 30, 2017 •

edited

Loading

dgrove commented May 12, 2017

vsmenon commented May 13, 2017

matanlurey commented May 13, 2017 via email

vsmenon commented Jul 21, 2017

jmesserly commented Sep 25, 2017

munificent commented Dec 13, 2017 •

edited

Loading

natebosch commented Aug 24, 2018

vsmenon commented Aug 24, 2018

Remove ignored type failures #27223

Remove ignored type failures #27223

Comments

jmesserly commented Sep 1, 2016

jmesserly commented Sep 1, 2016

vsmenon commented Jan 24, 2017

vsmenon commented Mar 30, 2017 • edited Loading

dgrove commented May 12, 2017

vsmenon commented May 13, 2017

matanlurey commented May 13, 2017 via email

vsmenon commented Jul 21, 2017

jmesserly commented Sep 25, 2017

munificent commented Dec 13, 2017 • edited Loading

natebosch commented Aug 24, 2018

vsmenon commented Aug 24, 2018

vsmenon commented Mar 30, 2017 •

edited

Loading

munificent commented Dec 13, 2017 •

edited

Loading