-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GN build for Dart SDK #27406
Comments
I'll do "Add gn binary download to repo checkout". |
Started working on this here: https://codereview.chromium.org/2350583002/ |
The GN build can now produce the SDK on all platforms, including cross-builds, Android, and ASAN on Linux. It's wired up to both @whesse Can we get this set up on a builder or two? |
Wonderful! I'll set up builder/testers for this. We will need documentation about how to update this and GYP (and blaze) in simple cases like adding a source file to the build of a target. But that is mostly in VM, and you guys know already how to do it. |
BUG=#27406 R=rnystrom@google.com, zra@google.com Review URL: https://codereview.chromium.org/2412553002 .
I get the above error when attempting to use the GN build on windows. |
@mfrancis107 Thanks for the report. Did you follow the instructions here and set |
@zanderso Manually setting the environment variable worked. However, I think this can be resolved in the build steps. It looks like in |
I've created a new issue for the environment variable situation, which is not a blocker for the GN build. There may also still be a few other small issues remaining with the GN build, but we should file issues for those separately as well as they come up, so I'll go ahead and close this one. |
"Some people want to extend the GN build to the full Dart SDK.". It is currently working to build the runtime in the flutter context.
Here is a checklist of things that we would need to add:
The text was updated successfully, but these errors were encountered: