Greencat library usage crashes the compiler #28749

sturmf · 2017-02-11T08:57:02Z

Hi, it seems I can no longer use https://github.com/alexeieleusis/greencat/ with dart, the compiler crashes when I use it. Right now I am not sure if it is the compiler at fault or if it trips on some problematic code.

Here is my code which produces the error: https://github.com/sturmf/regatta-angular2/tree/REG-51-switch-to-redux-arc

My dart SDK version is Dart VM version: 1.21.1 on Ubuntu Linux 16.04.

The compiler crashed when compiling this element.
Store.createStore(Reducer<S, A> reducer, {S initialState, Function enhancer})
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The compiler is broken.

When compiling the above element, the compiler crashed. It is not
possible to tell if this is caused by a problem in your program or
not. Regardless, the compiler should not crash.

The Dart team would greatly appreciate if you would take a moment to
report this problem at http://dartbug.com/new.

Please include the following information:

the name and version of your operating system,
the Dart SDK build number (build number could not be determined), and
the entire message you see here (including the full stack trace
below as well as the source location above).

Build error:
Transform Dart2JS on frontend|test/event_list_test.da dart:core package:compiler_unsupported/src/ssa/codegen.dart 2995 package:compiler_unsupported/src/js_backend/runtime_types.dart package:compiler_unsupported/src/dart_types.dart 233 package:compiler_unsupported/src/js_backend/runtime_types.dart package:compiler_unsupported/src/js_backend/runtime_types.dart package:compiler_unsupported/src/js_backend/runtime_types.dart package:compiler_unsupported/src/dart_types.dart 552 package:compiler_unsupported/src/js_backend/runtime_types.dart package:compiler_unsupported/src/js_backend/runtime_types.dart package:compiler_unsupported/src/js_backend/runtime_types.dart package:compiler_unsupported/src/dart_types.dart 730 package:compiler_unsupported/src/js_backend/runtime_types.dart package:compiler_unsupported/src/js_backend/runtime_types.dart package:compiler_unsupported/src/js_backend/runtime_types.dart package:compiler_unsupported/src/ssa/codegen.dart 2994 package:compiler_unsupported/src/ssa/nodes.dart 3365 package:compiler_unsupported/src/ssa/codegen.dart 661 package:compiler_unsupported/src/ssa/codegen.dart 667 package:compiler_unsupported/src/ssa/codegen.dart 648 package:compiler_unsupported/src/ssa/codegen.dart 2987 package:compiler_unsupported/src/ssa/nodes.dart 3365 package:compiler_unsupported/src/ssa/codegen.dart 661 package:compiler_unsupported/src/ssa/codegen.dart 667 package:compiler_unsupported/src/ssa/codegen.dart 648 package:compiler_unsupported/src/ssa/codegen.dart 538 package:compiler_unsupported/src/ssa/codegen.dart 1827 package:compiler_unsupported/src/ssa/nodes.dart 1667 package:compiler_unsupported/src/ssa/codegen.dart 661 package:compiler_unsupported/src/ssa/codegen.dart 667 package:compiler_unsupported/src/ssa/codegen.dart 633 package:compiler_unsupported/src/ssa/codegen.dart 1287 package:compiler_unsupported/src/ssa/codegen.dart 1177 package:compiler_unsupported/src/ssa/codegen.dart 1434 package:compiler_unsupported/src/ssa/nodes.dart 2181 package:compiler_unsupported/src/ssa/codegen.dart 661 package:compiler_unsupported/src/ssa/codegen.dart 1292 package:compiler_unsupported/src/ssa/codegen.dart 1177 package:compiler_unsupported/src/ssa/codegen.dart 375 package:compiler_unsupported/src/ssa/codegen.dart 90 package:compiler_unsupported/src/common/tasks.dart 63 package:compiler_unsupported/src/ssa/codegen.dart 84 package:compiler_unsupported/src/ssa/codegen.dart 66 package:compiler_unsupported/src/ssa/ssa.dart 43 package:compiler_unsupported/src/js_backend/backend.dart 1548 package:compiler_unsupported/src/common/codegen.dart 243 package:compiler_unsupported/src/compiler.dart 866 package:compiler_unsupported/src/common/tasks.dart 176 package:compiler_unsupported/src/compiler.dart 866 package:compiler_unsupported/src/common/tasks.dart 176 package:compiler_unsupported/src/compiler.dart 864 package:compiler_unsupported/src/compiler.dart 1623 package:compiler_unsupported/src/compiler.dart 862 package:compiler_unsupported/src/enqueue.dart 749 package:compiler_unsupported/src/js_backend/enqueuer.dart 452 package:compiler_unsupported/src/compiler.dart 858 package:compiler_unsupported/src/common/tasks.dart 176 package:compiler_unsupported/src/compiler.dart 857 package:compiler_unsupported/src/compiler.dart 886 package:compiler_unsupported/src/common/tasks.dart 176 package:compiler_unsupported/src/compiler.dart 875 package:compiler_unsupported/src/compiler.dart 757 package:compiler_unsupported/src/common/tasks.dart 176 package:compiler_unsupported/src/compiler.dart 646 package:compiler_unsupported/src/compiler.dart 554 rt.browser_test.dart threw error: RangeError (index): Invalid value: Not in range 0..2, inclusive: 3
List.[]
SsaCodeGenerator.visitTypeInfoExpression.
801 TypeRepresentationGenerator.visitTypeVariableType
TypeVariableType.accept
798 TypeRepresentationGenerator.visit
819 TypeRepresentationGenerator.visitList
810 TypeRepresentationGenerator.visitInterfaceType
InterfaceType.accept
798 TypeRepresentationGenerator.visit
819 TypeRepresentationGenerator.visitList
861 TypeRepresentationGenerator.visitFunctionType
FunctionType.accept
798 TypeRepresentationGenerator.visit
787 TypeRepresentationGenerator.getTypeRepresentation
612 _RuntimeTypesEncoder.getTypeRepresentation
SsaCodeGenerator.visitTypeInfoExpression
HTypeInfoExpression.accept
SsaCodeGenerator.visit
SsaCodeGenerator.visitExpression
SsaCodeGenerator.use
SsaCodeGenerator.visitTypeInfoExpression
HTypeInfoExpression.accept
SsaCodeGenerator.visit
SsaCodeGenerator.visitExpression
SsaCodeGenerator.use
SsaCodeGenerator.visitArguments
SsaCodeGenerator.visitInvokeStatic
HInvokeStatic.accept
SsaCodeGenerator.visit
SsaCodeGenerator.visitExpression
SsaCodeGenerator.define
SsaCodeGenerator.iterateBasicBlock
SsaCodeGenerator.visitBasicBlock
SsaCodeGenerator.visitGoto
HGoto.accept
SsaCodeGenerator.visit
SsaCodeGenerator.iterateBasicBlock
SsaCodeGenerator.visitBasicBlock
SsaCodeGenerator.visitGraph
SsaCodeGeneratorTask.generateMethod.
CompilerTask.measure
SsaCodeGeneratorTask.generateMethod
SsaCodeGeneratorTask.generateCode
SsaFunctionCompiler.compile
JavaScriptBackend.codegen
CodegenWorkItem.run
Compiler.emptyQueue.....
CompilerTask.measureSubtask
Compiler.emptyQueue....
CompilerTask.measureSubtask
Compiler.emptyQueue...
CompilerDiagnosticReporter.withCurrentElement
Compiler.emptyQueue..
EnqueuerStrategy.processWorkItem
CodegenEnqueuer.forEach
Compiler.emptyQueue.
CompilerTask.measureSubtask
Compiler.emptyQueue
Compiler.processQueue.
CompilerTask.measureSubtask
Compiler.processQueue
Compiler.compileLoadedLibraries.
CompilerTask.measureSubtask
Compiler.compileLoadedLibraries
Compiler.runInternal.

Build completed with 2 errors.

alexeieleusis · 2017-02-12T06:31:58Z

You seem to be using https://github.com/dart-lang/compiler_unsupported have you tried with stable dart2js?

sturmf · 2017-02-12T09:49:47Z

@alexeieleusis thanks for that info, I never saw that it printed compiler_unsupported! I wonder how that gets pulled in, I am using dart_to_js_script_rewriter: ^1.0.1 which I thought would be fine. Researching that now.

sturmf · 2017-02-14T21:34:42Z

Hmm everything is now ported to the latest version. For completeness. This is my pubspec.yaml. Anything wrong with it that would pull in the unsupported compiler?

name: frontend
version: 0.0.1
description: Regatta frontend
author:
homepage: https://regatta.atlassian.net
documentation:

environment:
  sdk: '>=1.19.0 <2.0.0'

dependencies:
  angular2: 3.0.0-alpha
  angular2_components: 0.3.1-alpha
  reflectable: 1.0.1
  sass_transformer: 0.1.2+1
  greencat: 0.0.2
  browser: 0.10.0+2
  http: 0.11.3+9
  stream_transformers: 0.3.0+3

dev_dependencies:
  test: 0.12.19
  dart_to_js_script_rewriter: 1.0.2
  dart_style: 0.2.16
  pageloader: 2.2.5
  mockito: 1.0.1
  angular_test: 1.0.0-alpha+5

transformers:
  - angular2/transform/codegen:
      platform_directives:
        - 'package:angular2/common.dart#COMMON_DIRECTIVES'
      platform_pipes:
        - 'package:angular2/common.dart#COMMON_PIPES'
      entry_points: web/main.dart
      resolved_identifiers:
        BrowserClient: 'package:http/browser_client.dart'
        Client: 'package:http/http.dart'
  - angular2/transform/reflection_remover:
      $include:
        - test/**_test.dart
        - web/main.dart
  #- reflectable:
  #    entry_points:
  #      - web/main.dart
  #    formatted: true
  - test/pub_serve:
      $include: test/**_test.dart
  - dart_to_js_script_rewriter
  - sass_transformer

sigmundch · 2017-02-15T00:35:53Z

@sturmf - you can ignore the compiler_unsupported bit - that's just because pub invokes dart2js by importing it using this package. It is however the same dart2js that got shipped with your SDK, as far as I know.

If you are really curious, you can confirm this by excluding dart2js from pub-build and running dart2js manually (e.g. by adding a transformer that skips dart2js:

- $dart2js:
    $include: []  # nothing goes through dart2js

), running pub build --mode debug to generate dart files in the build folder, and finally calling dart2js on the generated test/event_list_test.dart.browser_test.dart file by hand.

@rakudrama - looks like an issue related to our RTI encoding
https://github.com/dart-lang/sdk/blob/1.21.1/pkg/compiler/lib/src/ssa/codegen.dart#L2995

rakudrama · 2017-02-15T00:59:16Z

Can you attach test/event_list_test.dart.browser_test.dart ?

sturmf · 2017-02-15T07:09:09Z

Hmm I didn't figure out how to attach a file so here it is inline:

// Because Angular is using dart:html, we need these tests to run on an actual
// browser. This means that it should be run with `-p dartium` or `-p chrome`.
@Tags(const ['aot'])
@TestOn('browser')
import 'package:angular2/angular2.dart';
import 'package:angular_test/angular_test.dart';
import 'package:test/test.dart';

import 'package:angular2/router.dart';
import 'package:mockito/mockito_no_mirrors.dart';

import 'package:frontend/store/regatta_store.dart';
import 'package:frontend/components/event_list_component/event_list_component.dart';
import 'package:frontend/components/event_list_component/event_list_component_po.dart';
import 'package:frontend/models/event.dart';

// We have to wrap our component in a slim wrapper to resolve it with getInstance later
@Component(selector: 'test', directives: const [EventListComponent], template: '<my-event-list></my-event-list>')
class EventListTestComponent {}

@AngularEntrypoint()
void main() {
  tearDown(disposeAnyRunningTest);

  test('EventListComponent list contains dummy event', () async {
    final router = new MockRouter();
    final regattaStore = new MockRegattaStore();

    when(regattaStore.state.events).thenReturn({1: new Event(1, 'dummy url', 'Dummy Event')});

    final testBed = new NgTestBed<EventListTestComponent>().addProviders([
      provide(Router, useValue: router),
      provide(RegattaStore, useValue: regattaStore),
    ]);

    final fixture = await testBed.create();

    // Get a handle to the list.
    final pageObject = await fixture.resolvePageObject/*<EventListPO>*/(
      EventListPO,
    );

    final items = await pageObject.items;
    await expect(items, hasLength(1));
    await expect(await items[0].visibleText, equals('Dummy Event'));

    regattaStore.close();
  });
}

And this is the way I run it. Call pub serve in one terminal and pub run test -p dartium --pub-serve=8081

The source is also available here: https://github.com/sturmf/regatta-angular2/blob/REG-51-switch-to-redux-arc/frontend/test/event_list_test.dart

zoechi · 2017-02-15T07:13:34Z

shouldn't the sass_transformer come before angular2?
Angular2 depends on the CSS files to exist.

sturmf · 2017-02-27T06:13:02Z

@sigmundch Hmm I tried to create the transpiled file. But since it only gets created during the test run I didn't manage to get hold of it. Any ideas how I could get at it? What would the pubspec look like and do I do pub serve --mode debug or more?

sigmundch · 2017-03-10T22:59:01Z

Mmm - good question, not sure, is the error above something you see in your pub-serve terminal or in your pub-run-test terminal?

If it is in the pub-serve terminal, then here is what you can do:

update pubspec to skip dart2js like this:

name: frontend
version: 0.0.1
description: Regatta frontend
author:
homepage: https://regatta.atlassian.net
documentation:

environment:
  sdk: '>=1.19.0 <2.0.0'

dependencies:
  angular2: 3.0.0-alpha
  angular2_components: 0.3.1-alpha
  reflectable: 1.0.1
  sass_transformer: 0.1.2+1
  greencat: 0.0.2
  browser: 0.10.0+2
  http: 0.11.3+9
  stream_transformers: 0.3.0+3

dev_dependencies:
  test: 0.12.19
  dart_to_js_script_rewriter: 1.0.2
  dart_style: 0.2.16
  pageloader: 2.2.5
  mockito: 1.0.1
  angular_test: 1.0.0-alpha+5

transformers:
  - angular2/transform/codegen:
      platform_directives:
        - 'package:angular2/common.dart#COMMON_DIRECTIVES'
      platform_pipes:
        - 'package:angular2/common.dart#COMMON_PIPES'
      entry_points: web/main.dart
      resolved_identifiers:
        BrowserClient: 'package:http/browser_client.dart'
        Client: 'package:http/http.dart'
  - angular2/transform/reflection_remover:
      $include:
        - test/**_test.dart
        - web/main.dart
  #- reflectable:
  #    entry_points:
  #      - web/main.dart
  #    formatted: true
  - test/pub_serve:
      $include: test/**_test.dart
  - dart_to_js_script_rewriter
  - sass_transformer

  ### extra transformer to skip dart2js:
  - $dart2js:
      $include: []  # nothing goes through dart2js
  ###

Instead of calling pub-serve, you can call pub-build in debug mode on the test folder:

pub build test --mode=debug

You should be able to see the file in build/test/. And a stand-alone version of dart2js will likely crash too:

dart2js build/test/event_list_test.dart.browser_test.dart

sigmundch · 2017-03-10T23:39:42Z

Ok - turns out we can reproduce this even if we compile the test without running any transformers. It might be somethign that only comes up because of the use of dart:mirrors though (I noticed that the transformed program still contains calls to mirrors too).

Here is a repro with your current project - I yet have to reduce this further to a simple test case:

git clone git@github.com:sturmf/regatta-angular2.git
pub get
dart2js test/event_list_test.dart

sigmundch · 2017-03-10T23:54:05Z

@rakudrama - here is a simpler repro, it still pulls the greencat dependency, but it's much smaller:

pubspec.yaml:

name: repro
dependencies:
  greencat: any

a.dart:

import 'dart:mirrors';
import 'package:greencat/greencat.dart';

void main() {
  reflectClass(Store);
}

repro:

pub get
dart2js a.dart

sigmundch · 2017-03-11T00:24:21Z

And here is a standalone repro, with no dependencies:

import 'dart:mirrors';

typedef void F<T>(T value);
typedef F<T> Converter<T>(F<T> function);
typedef Converter<T> ConvertFactory<T>(int input);

class B<T> {
  final field = <ConvertFactory<T>>[];
}

void main() {
  reflectClass(B);
}

rakudrama · 2017-04-12T20:09:28Z

Standalone repro without mirrors:

typedef void F<T>(T value);
typedef F<U> Converter<U>(F<U> function);
typedef Converter<V> ConvertFactory<V>(int input);

class B<W> {
  final field = <ConvertFactory<W>>[];
  B(){return;return;}
}

void main() {
  print(new B<int>().field.runtimeType);
}

The crash is because the type parameter for the list allocation, ConvertFactory<W>, when fully expanded as a tree, contains many references to W, whereas the inputs are expected to supply all type variables in the order present in the expansion.

e.g. if I change W to String, the above program on dart2js prints:

JSArray<(int) => ((String) => void) => (String) => void>

I see two ways to fix dart2js at this point:

Keep the typedef terms in the type. This complicates the reified types but preserves typedef information.
Expand typedefs in two steps - bind parameters and then generate the replacement that might share parameters.

I'm inclined to start with the second option, since kernel does not contain typedef nodes.

@asgerf dartk fully expands the typedefs, a potentially exponential operation. What is the plan for kernel for handling type terms that are DAGs? The dartk printout for the above program duplicates the inner function type, but is it not clear of this real duplication or a shared structure printed twice. For optimization, we want to do type algebra without the exponential expansion.

asgerf · 2017-04-13T11:02:56Z

@rakudrama I've written up all the boilerplate for typedefs in kernel, but the frontend and backend work is not done. It will probably land next week.

The type Map<T, Foo<Set<T>>> contains one type variable referenced twice, so there are two inputs into the HTypeInfoExpression instruction. If Foo is a typedef, T can be reused, e.g. typedef E Foo<E>(E a, E b); As the typedef is expanded (to Function(Set<T>, Set<T>) => Set<T>) it should not consume additional types from the to-level input. We prevent this by capturing the types and using the captured type expressions inside the typedef expansion. TODO: We should make the type subexpression Foo<...> be a second HTypeInfoExpression, with Set<T> as its input (a third HTypeInfoExpression). This would share all the Set<T> subexpressions instead of duplicating them. This would require HTypeInfoExpression inputs to correspond to type variables AND typedefs. BUG= #28749 R=efortuna@google.com Review-Url: https://codereview.chromium.org/2812393003 .

rakudrama · 2017-04-14T19:23:04Z

Fixed via d15da7d

alexeieleusis mentioned this issue Feb 11, 2017

Greencat crashes the dart compiler #28751

Closed

vsmenon added the web-dart2js label Feb 14, 2017

sigmundch assigned rakudrama Feb 15, 2017

rakudrama closed this as completed Apr 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Greencat library usage crashes the compiler #28749

Greencat library usage crashes the compiler #28749

sturmf commented Feb 11, 2017

alexeieleusis commented Feb 12, 2017

sturmf commented Feb 12, 2017

sturmf commented Feb 14, 2017

sigmundch commented Feb 15, 2017

rakudrama commented Feb 15, 2017

sturmf commented Feb 15, 2017 •

edited

Loading

zoechi commented Feb 15, 2017

sturmf commented Feb 27, 2017

sigmundch commented Mar 10, 2017

sigmundch commented Mar 10, 2017

sigmundch commented Mar 10, 2017

sigmundch commented Mar 11, 2017

rakudrama commented Apr 12, 2017

asgerf commented Apr 13, 2017

rakudrama commented Apr 14, 2017

Greencat library usage crashes the compiler #28749

Greencat library usage crashes the compiler #28749

Comments

sturmf commented Feb 11, 2017

alexeieleusis commented Feb 12, 2017

sturmf commented Feb 12, 2017

sturmf commented Feb 14, 2017

sigmundch commented Feb 15, 2017

rakudrama commented Feb 15, 2017

sturmf commented Feb 15, 2017 • edited Loading

zoechi commented Feb 15, 2017

sturmf commented Feb 27, 2017

sigmundch commented Mar 10, 2017

sigmundch commented Mar 10, 2017

sigmundch commented Mar 10, 2017

sigmundch commented Mar 11, 2017

rakudrama commented Apr 12, 2017

asgerf commented Apr 13, 2017

rakudrama commented Apr 14, 2017

sturmf commented Feb 15, 2017 •

edited

Loading