Ship a compatible version of require.js under sdk/lib/dev_compiler/amd

[jakemac53]

When compiling ddc using amd modules (the first strategy I am targeting right now), users currently need to grab their own copy of require.js or point at a cdn.

I propose that we ship a compatible version with the sdk, and then the transformer will copy that file next to your entry point script and edit your html to go from:

<script type="application/dart" src="main.dart"></script>
to
<script data-main="main.dart" src="require.js"></script>

[jakemac53]

cc @kevmoo @jmesserly

[jmesserly]

seems reasonable to me 👍

[vsmenon]

We probably need to:

[] add requirejs github to DEPS or download the built file as part of gclient runhooks
[] copy it alongside amd/dart_sdk.js into the built sdk as part of the build process
[] update whatever license we need to appropriately

@whesse - that sound right?

[whesse]

Yes, follow the procedure in the wiki for adding third-party dependencies.

…

On Mar 22, 2017 23:41, "vsmenon" ***@***.***> wrote: We probably need to: [] add requirejs github to DEPS or download the built file as part of gclient runhooks [] copy it alongside amd/dart_sdk.js into the built sdk as part of the build process [] update whatever license we need to appropriately @whesse <https://github.com/whesse> - that sound right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29140 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AErapwJGU_n38YfKHi2NKMPkLaB_P7ROks5roaOLgaJpZM4MlpAe> .

[vsmenon]

Thanks, this is the relevant wiki page:

https://github.com/dart-lang/sdk/wiki/Adding-and-Updating-Dependencies