Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotated import/export/part directives cause crash in DeclarationResolver #29188

Closed
scheglov opened this issue Mar 29, 2017 · 1 comment
Closed

Annotated import/export/part directives cause crash in DeclarationResolver #29188

scheglov opened this issue Mar 29, 2017 · 1 comment
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
1.24

Comments

@scheglov
Copy link
Contributor

scheglov commented Mar 29, 2017 •
edited
Loading

I'm adding a failing new test to AnalysisDriver test_getResult_invalidUri_metadata.

This show the problems that you and Paul discussed a couple of weeks ago - what to do for invalid URIs - create or not corresponding elements. If there is no element, there is nothing to associate annotations with.
@scheglov scheglov added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures labels Mar 29, 2017
@scheglov scheglov added this to the 1.24 milestone Mar 29, 2017
scheglov added a commit that referenced this issue Mar 29, 2017
@scheglov
Issue 29188. Failing test.
1944172 
R=brianwilkerson@google.com
BUG= #29188

Review-Url: https://codereview.chromium.org/2785613002 .
@scheglov scheglov mentioned this issue Apr 7, 2017
Closed
scheglov added a commit that referenced this issue Apr 9, 2017
@scheglov
Issue 29288. Resynthesize Import/Export/PartElement for every directive.
021d99e 
We need all of them because there might be associated annotations,
which should be applied to corresponding AST nodes.

#29288
#29188

R=brianwilkerson@google.com
BUG= #29288

Review-Url: https://codereview.chromium.org/2809523002 .
@scheglov scheglov self-assigned this Apr 9, 2017
@scheglov
Copy link
Contributor Author

scheglov commented Apr 9, 2017

Fixed in 021d99e.

@scheglov scheglov closed this as completed Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
1.24
Development

No branches or pull requests
1 participant
@scheglov