Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK zip includes folders like lib/analyzer/test and lib/front_end/testcases #29852

Closed
mraleph opened this issue Jun 13, 2017 · 4 comments
Closed

SDK zip includes folders like lib/analyzer/test and lib/front_end/testcases #29852

mraleph opened this issue Jun 13, 2017 · 4 comments
Assignees
@scheglov
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …).

Comments

@mraleph
Copy link
Member

mraleph commented Jun 13, 2017

I don't think this files should be shipped as part of SDK.

/cc @peter-ahe-google @whesse
@mraleph mraleph added the area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). label Jun 13, 2017
@peter-ahe-google peter-ahe-google added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label Jun 13, 2017
@peter-ahe-google
Copy link
Contributor

/cc @stereotype441 @scheglov

@scheglov
Copy link
Contributor

I agree. Actually by some reason we ship test folders for all packages - analyzer, analysis_server and front_end.

@scheglov
Copy link
Contributor

https://codereview.chromium.org/2940723002 maybe?

scheglov added a commit that referenced this issue Jun 14, 2017
@scheglov
Exclude 'test' and 'testcases' from lib/ packages.
b2b98bb 
R=paulberry@google.com, whesse@google.com
BUG= #29852

Review-Url: https://codereview.chromium.org/2940723002 .
@sigmundch
Copy link
Member

I believe @scheglov fixed it with his change, please reopen if that's not the case.

@scheglov scheglov self-assigned this Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mraleph @scheglov @sigmundch @peter-ahe-google