Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New heap always reported as full even if it is not #30311

Closed
B3rn475 opened this issue Aug 1, 2017 · 2 comments
Closed

New heap always reported as full even if it is not #30311

B3rn475 opened this issue Aug 1, 2017 · 2 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@B3rn475
Copy link
Contributor

B3rn475 commented Aug 1, 2017

The new heap is always reported to be full by the Scavenger.

Run script:

import 'dart:async' show Timer, Duration;

final waste = [];

void topLevel(period) {
  new Timer.periodic(period, (Timer t) {
    waste.add(new List.filled(10000, 5));
  });
}

main() {
  topLevel(const Duration(seconds: 1));
}

Open Observatory in the Allocation Profile page

@B3rn475 B3rn475 added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Aug 1, 2017
@dnunez02
Copy link
Contributor

dnunez02 commented Aug 1, 2017

The new space uses top_ to determine how many words the new space is using. However, that information is in the mutator thread local state now.

I will update the appropriate functions to use the proper data.

@dnunez02
Copy link
Contributor

dnunez02 commented Aug 1, 2017

dnunez02 added a commit that referenced this issue Aug 7, 2017
Once again fixes #30311

The previous commit for this issue (044f818) was reverted to
fix a bug. This CL avoids writing to the TLAB to measure the
usage.

R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2993203002 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

2 participants