-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobuf generation fails when run with front end #31480
Comments
There are two issues in the front end, both of which need to be fixed:
|
Kevin, could you make this a priority? I can't continue testing in google3 until this is fixed. |
Yes, we would want to run the vm with the suppress warnings flag. We have other instances in the internal workflow where the stdout from the cli is used - as in the case of analyzer. |
This is the issue where |
I have a fix for the first issue, involving the reserved word The second issue, involving suppressing warnings, still affects the plugin because there are other warnings besides the bogus ones due to |
Proposed fix for warnings, print them on stderr. |
`void` will be a reserved word in Dart 2.0 (it always was in Dart 1.x). Remove it as an exported name from dart:core because it could be accidentally hidden. Bug: #31480 Change-Id: Id804cccbc144f3c8ba2fc9898a3b5c79e238ab36 Reviewed-on: https://dart-review.googlesource.com/24940 Reviewed-by: Peter von der Ahé <ahe@google.com> Commit-Queue: Kevin Millikin <kmillikin@google.com>
I think both of the underlying problems are now fixed. Please reopen this issue if you see the same or related problems. |
Running the dart-protoc-plugin with the VM+FE fails with the message
--dart_out: protoc-gen-dart: Plugin output is unparseable:
The file lib/src/dart_options.pb.dart this line which hides 'void' from dart:core
///
// Generated code. Do not modify.
///
// ignore_for_file: non_constant_identifier_names,library_prefixes
library dart_options_dart_options;
// ignore: UNUSED_SHOWN_NAME
import 'dart:core' show int, bool, double, String, List, override;
which could be the issue.
The text was updated successfully, but these errors were encountered: