Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in HttpClient.findProxyFromEnvironment documentation #31538

Closed
sgrekhov opened this issue Dec 5, 2017 · 0 comments
Closed

Typo in HttpClient.findProxyFromEnvironment documentation #31538

sgrekhov opened this issue Dec 5, 2017 · 0 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io type-documentation A request to add or improve documentation

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Dec 5, 2017

Please see HttpClient.findProxyFromEnvironment

If you don't want to use the system environment you can use a different one by wrapping the function.

HttpClient client = new HttpClient();
client.findProxy = (url) {
return HttpClient.findProxyFromEnvironment(
url, {"http_proxy": ..., "no_proxy": ...});
}

The second argument of findProxyFromEnvironment is named, so change the code to:

HttpClient client = new HttpClient();
client.findProxy = (url) {
  return HttpClient.findProxyFromEnvironment(
      url, environment: {"http_proxy": ..., "no_proxy": ...}); 
}
@anders-sandholm anders-sandholm added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io type-documentation A request to add or improve documentation labels Dec 6, 2017
whesse pushed a commit that referenced this issue Dec 18, 2017
In particular, fix typos, and update many comments to begin with a one-sentence
summary, for better readability at api.dartlang.org.

Fixes #31608, #29460, #31538, #31449, #31505

Bug: #31608
Bug: #29460
Bug: #31538
Bug: #31449
Bug: #31505
Change-Id: If00726ef3636479f0613c91e48ff9f0e24b12502
Reviewed-on: https://dart-review.googlesource.com/30120
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io type-documentation A request to add or improve documentation
Projects
None yet
Development

No branches or pull requests

3 participants