Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Function detected too late during DWARF generation: Function: null" #31952

Closed
zanderso opened this issue Jan 19, 2018 · 4 comments
Closed

"Function detected too late during DWARF generation: Function: null" #31952

zanderso opened this issue Jan 19, 2018 · 4 comments
Assignees
@rmacnak-google
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. front-end-kernel gardening type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@zanderso
Copy link
Member

A flaky-looking failure on:

$ tools/test.py -m release -c dartkp -r dart_precompiled co19/Language/Expressions/Lists/syntax_t01

gives:

../../runtime/vm/dwarf.cc: 122: error: Function detected too late during DWARF generation: Function: null

See:

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.dart%2Fvm-kernel-precomp-linux-release-x64-1-6-be%2F950%2F%2B%2Frecipes%2Fsteps%2Fvm_tests%2F0%2Fstdout

/cc @rmacnak-google @mraleph
@zanderso zanderso added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) area-kernel gardening labels Jan 19, 2018
@rmacnak-google
Copy link
Contributor

Something like this could happen if the compiler inserts a null into RawCode::inlined_id_to_function_.

@alexmarkov
Copy link
Contributor

Same crash happened today on a buildbot:

FAILED: dartkp-dart_precompiled release_x64 lib/typed_data/typed_data_load2_test
Expected: Pass
Actual: Crash
Unexpected compile error.
--- Command "vm_compile_to_kernel" (took 629ms):
DART_CONFIGURATION=ReleaseX64 /b/build/slave/vm-kernel-precomp-linux-release-x64-1-6-be/build/sdk/pkg/vm/tool/gen_kernel --aot --no-strong-mode --no-sync-async --platform=out/ReleaseX64/vm_platform.dill -o /b/build/slave/vm-kernel-precomp-linux-release-x64-1-6-be/build/sdk/out/ReleaseX64/generated_compilations/dartkp/tests_lib_typed_data_typed_data_load2_test/out.dill /b/build/slave/vm-kernel-precomp-linux-release-x64-1-6-be/build/sdk/tests/lib/typed_data/typed_data_load2_test.dart
exit code:
0
--- Command "precompiler" (took 04.000615s):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart_bootstrap --snapshot-kind=app-aot --snapshot=/b/build/slave/vm-kernel-precomp-linux-release-x64-1-6-be/build/sdk/out/ReleaseX64/generated_compilations/dartkp/tests_lib_typed_data_typed_data_load2_test/out.S --ignore-unrecognized-flags --packages=/b/build/slave/vm-kernel-precomp-linux-release-x64-1-6-be/build/sdk/.packages /b/build/slave/vm-kernel-precomp-linux-release-x64-1-6-be/build/sdk/out/ReleaseX64/generated_compilations/dartkp/tests_lib_typed_data_typed_data_load2_test/out.dill
exit code:
-6
stderr:
../../runtime/vm/dwarf.cc: 122: error: Function detected too late during DWARF generation: Function: null
Dumping native stack trace for thread 7c8
  [0x0000000000c995b7] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000c995b7] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000eeacd9] dart::DynamicAssertionHelper::Fail(char const*, ...)
  [0x0000000000b60308] dart::Dwarf::WriteInliningNode(dart::InliningNode*, long, dart::Script const&)
  [0x0000000000b5f9a1] dart::Dwarf::WriteConcreteFunctions()
  [0x0000000000b5f4d1] dart::Dwarf::WriteCompilationUnit()
  [0x0000000000b753ad] dart::AssemblyImageWriter::Finalize()
  [0x0000000000edfd1f] Dart_CreateAppAOTSnapshotAsAssembly
  [0x000000000096a69f] dart::bin::Snapshot::GenerateAppAOTAsAssembly(char const*)
  [0x0000000000966ade] dart::bin::RunMainIsolate(char const*, dart::bin::CommandLineOptions*)
  [0x00000000009672dd] dart::bin::main(int, char**)
  [0x0000000000967a49] Unknown symbol
-- End of DumpStackTrace
--- Re-run this test:
python tools/test.py -m release -c dartkp -r dart_precompiled lib/typed_data/typed_data_load2_test

dart-bot pushed a commit that referenced this issue Feb 9, 2018
@rmacnak-google
[vm, aot] Debugging aids for null function encountered when writing D…
692eaba 
…WARF inlining data.

Bug: #31952
Change-Id: I884c1a0c6f7255935743c4ec7c78c9501708a2f7
Reviewed-on: https://dart-review.googlesource.com/40203
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
@mraleph mraleph mentioned this issue Feb 13, 2018
Closed
@mraleph
Copy link
Member

mraleph commented Feb 15, 2018

This is flaking all the time on the bot. Is there anything we could enable to help debugging this?

dart-bot pushed a commit that referenced this issue Feb 16, 2018
@rmacnak-google
[vm, aot] Further debugging aids for null function encountered when w…
0410079 
…riting DWARF inlining data.

Bug: #31952
Change-Id: Iaf677c2dd15567772d1bb9f2482e749ef1139fe2
Reviewed-on: https://dart-review.googlesource.com/42060
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
dart-bot pushed a commit that referenced this issue Feb 16, 2018
@rmacnak-google
[vm, aot] Further debugging aids for null function encountered when w…
0916763 
…riting DWARF inlining data.

Bug: #31952
Change-Id: Ice62439ac2a3a762d7876b8258f00a2489bdce4c
Reviewed-on: https://dart-review.googlesource.com/42121
Reviewed-by: Alexander Markov <alexmarkov@google.com>
@rmacnak-google
Copy link
Contributor

Cannot reproduce.

@kmillikin kmillikin added area-front-end Use area-front-end for front end / CFE / kernel format related issues. front-end-kernel and removed area-front-end Use area-front-end for front end / CFE / kernel format related issues. labels Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. front-end-kernel gardening type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mraleph @kmillikin @zanderso @rmacnak-google @alexmarkov