-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
final decls not really final #3209
Comments
https://chromiumcodereview.appspot.com/10442018 Added Started label. |
https://code.google.com/p/dart/source/detail?r=7972 Added Fixed label. |
copybara-service bot
pushed a commit
that referenced
this issue
Dec 1, 2021
Changes: ``` > git log --format="%C(auto) %h %s" b9edfa5..dcb6aba https://dart.googlesource.com/pub.git/+/dcb6abac Merge remote-tracking branch 'origin/cherry-pick2-for-2.15.0' https://dart.googlesource.com/pub.git/+/dc857523 Remove duplicated lines in testdata (#3234) https://dart.googlesource.com/pub.git/+/acc8ab09 Refactor the test package-server (#3230) https://dart.googlesource.com/pub.git/+/1e78c688 Better error messages round 2 (#3223) https://dart.googlesource.com/pub.git/+/eaf36513 More links in the repository specification (#3220) https://dart.googlesource.com/pub.git/+/c888b018 Remove pedantic and cleanup a few lints (#3224) https://dart.googlesource.com/pub.git/+/a4d44c7e Global package server null safety (#3225) https://dart.googlesource.com/pub.git/+/ff941887 Merge branch 'cherry-pick-for-2.15.0' https://dart.googlesource.com/pub.git/+/efd24e64 Fix hanging event handler for `stdin`. (#3218) https://dart.googlesource.com/pub.git/+/d77c14e8 Gitignore validator should not follow symlink dirs (#3209) https://dart.googlesource.com/pub.git/+/7c190789 migrate rest of test/ to null-safety (#3207) https://dart.googlesource.com/pub.git/+/f24adb64 migrate test/oath2/ test/outdated/ test/token test/validator/ to null-safety (#3206) https://dart.googlesource.com/pub.git/+/e7d77a57 migrate test/add, test/cache, test/embedding plus a bit more to null-safety (#3205) https://dart.googlesource.com/pub.git/+/a6a73ad2 migrate test/lish/, test/run/, test/upgrade/ and golden_file.dart to null-safety (#3204) https://dart.googlesource.com/pub.git/+/b90efc1f Add test that `pub get` works with no $HOME in environment. (#3173) https://dart.googlesource.com/pub.git/+/c2fe3966 migrate test/get/ to null-safety (#3203) https://dart.googlesource.com/pub.git/+/1d106898 migrate test/hosted/ to null-safety (#3200) https://dart.googlesource.com/pub.git/+/afa9932b migrate test/cache and test/downgrade/ to null-safety (#3201) https://dart.googlesource.com/pub.git/+/352ca989 migrate test/global/ to null-safety (#3202) https://dart.googlesource.com/pub.git/+/64f20ca4 migrate test/descriptor/ and couple more files in test/ to null-safety (#3192) ``` Diff: https://dart.googlesource.com/pub.git/+/b9edfa5e288ea3d1a57d1db054ef844ae7b27d99~..dcb6abac2d7d43258c03b348be42bf4aab9529b1/ Change-Id: I30d33b0b8c3c19097a16543db15c6ae633f0afc2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221633 Auto-Submit: Jonas Jensen <jonasfj@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Jonas Jensen <jonasfj@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Oct 10, 2022
…2 revisions) https://dart.googlesource.com/dartdoc/+log/c2f66ecf1a75..b3856970e4ab 2022-10-10 srawlins@google.com Remove 300 font weights, for improvements in dark mode (#3213) 2022-10-07 devoncarew@gmail.com Update README.md (#3209) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-doc-dart-sdk Please CC dart-ecosystem-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: dart-ecosystem-gardener@grotations.appspotmail.com Change-Id: I94b8a054e92d5d95cf89754ef65bd6158039e72f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263480 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Devon Carew <devoncarew@google.com> Commit-Queue: DEPS Autoroller <dart-autoroll@skia-public.iam.gserviceaccount.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This code should lead to three static type warnings but I get none. Assigning to x, y, or wob through a typed reference where the field is declared final should be flagged by the analyzer.
class Point {
final x, y;
Point(this.x, this.y);
}
interface Wobulator default WobulatorImpl {
Wobulator();
final wob;
}
class WobulatorImpl implements Wobulator {
var wob;
WobulatorImpl();
}
void main() {
Point p = new Point(2, 3);
p.x = 42;
p.y = 87;
Wobulator w = new Wobulator();
w.wob = 100;
}
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 7937
The text was updated successfully, but these errors were encountered: