Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homebrew (mac) installer should not install dartium and/or content-shell with -dev #32642

Closed
kevmoo opened this issue Mar 22, 2018 · 3 comments
Closed

Homebrew (mac) installer should not install dartium and/or content-shell with -dev #32642

kevmoo opened this issue Mar 22, 2018 · 3 comments
Assignees
@kevmoo
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …).
Milestone
Dart2 Beta 3

Comments

@kevmoo
Copy link
Member

kevmoo commented Mar 22, 2018

They are more than broken.

Something needs to be changed here:

sdk/tools/apps/update_homebrew/lib/update_homebrew.dart

Line 112 in 26c06cd

String createDartFormula(

@nex3 – any ideas how to do this cleanly-ish w/ Ruby?
@kevmoo kevmoo added the area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). label Mar 22, 2018
@kevmoo kevmoo added this to the Dart2 Beta 3 milestone Mar 22, 2018
@kevmoo kevmoo added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Mar 22, 2018
@kevmoo
Copy link
Member Author

kevmoo commented Mar 22, 2018

...at a minimum we should warn folks...

@nex3
Copy link
Member

nex3 commented Mar 22, 2018

This is less a Ruby question and more of a Homebrew API question, which I'm unfortunately not very familiar with.

@kevmoo
Copy link
Member Author

kevmoo commented Mar 22, 2018

CL https://dart-review.googlesource.com/c/sdk/+/48000

@kevmoo kevmoo assigned kevmoo and unassigned whesse Mar 22, 2018
athomas pushed a commit to dart-lang/homebrew-dart that referenced this issue Jun 4, 2021
@kevmoo @athomas
Update homebrew formula to fail with dartium on dev releases
cf523ea 
Closes dart-lang/sdk#32642

Change-Id: I221ec3cca7c6965a0feef1dd380160221e1b5fb2
Reviewed-on: https://dart-review.googlesource.com/48000
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
athomas pushed a commit to dart-lang/homebrew-dart that referenced this issue Jul 1, 2021
@kevmoo @athomas
Update homebrew formula to fail with dartium on dev releases
3f005a0 
Closes dart-lang/sdk#32642

Change-Id: I221ec3cca7c6965a0feef1dd380160221e1b5fb2
Reviewed-on: https://dart-review.googlesource.com/48000
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevmoo kevmoo

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …).
Projects
None yet
Milestone
Dart2 Beta 3
Development

No branches or pull requests
3 participants
@nex3 @kevmoo @whesse