Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

75a75263d35d998834ebccb319f18ab7e4877e5d Blocking Dart SDK Roll #33242

Closed
bkonyi opened this issue May 25, 2018 · 3 comments
Closed

75a75263d35d998834ebccb319f18ab7e4877e5d Blocking Dart SDK Roll #33242

bkonyi opened this issue May 25, 2018 · 3 comments
Assignees
@kmillikin
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P0 A serious issue requiring immediate resolution

Comments

@bkonyi
Copy link
Contributor

bkonyi commented May 25, 2018

Dart SDK roll into Flutter is blocked by failures caused by the following commit:

75a75263d35d998834ebccb319f18ab7e4877e5d is the first bad commit
commit 75a75263d35d998834ebccb319f18ab7e4877e5d
Author: Kevin Millikin <kmillikin@google.com>
Date:   Thu May 24 15:59:54 2018 +0000

    Clone annotations when cloning nodes that have them

    Annotations were not cloned.

    Fixes https://github.com/dart-lang/sdk/issues/33099

    Change-Id: I2d2b2153be9efcf1be4b39815eb8ac15b7cacd38
    Reviewed-on: https://dart-review.googlesource.com/56494
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    Commit-Queue: Kevin Millikin <kmillikin@google.com>

:040000 040000 84f727925c06e779c8cc1e71aa9d5709a6db41b9 c0b7ccf31492c8a660924376cf5dd4ea78a70796 M      pkg

Partial stacktrace:

00:16 +117: /home/travis/build/flutter/flutter sdk/packages/flutter/test/cupertino/scrollbar_paint_test.dart: - Paints iOS spec
The following TestFailure object was thrown running a test:
  Expected: Object or closure painting: 'a rounded rectangle with Color(0x99777777),
  RRect.fromLTRBR(795.0, 4.0, 797.5, 86.0, 1.3)'
  Actual: ?:<exactly one widget with type "CupertinoScrollbar" (ignoring offstage widgets):
  CupertinoScrollbar(state: _CupertinoScrollbarState#d8c59(tickers: tracking 1 ticker))>
   Which: threw the following exception:
          '': error: native function 'Canvas_translate' (3 arguments) cannot be found
          #0      _GlowingOverscrollIndicatorPainter._paintSide (package:flutter/src/widgets/overscroll_indicator.dart:493:16)
          #1      _GlowingOverscrollIndicatorPainter.paint (package:flutter/src/widgets/overscroll_indicator.dart:518:5)
          #2      RenderCustomPaint._paintWithPainter (package:flutter/src/rendering/custom_paint.dart:520:13)
          #3      RenderCustomPaint.paint (package:flutter/src/rendering/custom_paint.dart:563:7)
          #4      TestRecordingPaintingContext.paintChild (file:///home/travis/build/flutter/flutter%20sdk/packages/flutter/test/rendering/recording_canvas.dart:102:11)
          #5      _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:127:15)
          #6      TestRecordingPaintingContext.paintChild (file:///home/travis/build/flutter/flutter%20sdk/packages/flutter/test/rendering/recording_canvas.dart:102:11)
          #7      _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:127:15)
          #8      TestRecordingPaintingContext.paintChild (file:///home/travis/build/flutter/flutter%20sdk/packages/flutter/test/rendering/recording_canvas.dart:102:11)
          #9      _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:127:15)
          #10     RenderCustomPaint.paint (package:flutter/src/rendering/custom_paint.dart:561:11)
          #11     TestRecordingPaintingContext.paintChild (file:///home/travis/build/flutter/flutter%20sdk/packages/flutter/test/rendering/recording_canvas.dart:102:11)
          #12     _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:127:15)
          #13     _evaluatePainter (file:///home/travis/build/flutter/flutter%20sdk/packages/flutter/test/rendering/mock_canvas.dart:501:20)
          #14     _TestRecordingCanvasMatcher.matches (file:///home/travis/build/flutter/flutter%20sdk/packages/flutter/test/rendering/mock_canvas.dart:518:12)
          #15     _expect (package:test/src/frontend/expect.dart:155:17)
          #16     expect (package:test/src/frontend/expect.dart:69:3)

PR: flutter/flutter#17913
Travis: https://travis-ci.org/flutter/flutter/jobs/383847021
@bkonyi bkonyi added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P0 A serious issue requiring immediate resolution labels May 25, 2018
@bkonyi
Copy link
Contributor Author

bkonyi commented May 25, 2018

/cc @a-siva, @tvolkert

@tvolkert
Copy link
Contributor

Does 75a75263d35d998834ebccb319f18ab7e4877e5d revert cleanly?

@aam
Copy link
Contributor

aam commented May 25, 2018

It does https://dart-review.googlesource.com/#/c/sdk/+/56722

dart-bot pushed a commit that referenced this issue May 26, 2018
@aam
Revert "Clone annotations when cloning nodes that have them"
f981f09 
This reverts commit 75a7526 as it breaks Flutter

Bug: #33242
Change-Id: I825b0da4757f1ff9a318f8203605761d61d25e01
Reviewed-on: https://dart-review.googlesource.com/56722
Reviewed-by: Todd Volkert <tvolkert@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
@bkonyi bkonyi closed this as completed May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmillikin kmillikin

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P0 A serious issue requiring immediate resolution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aam @kmillikin @tvolkert @bkonyi