Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a replacement for AstRewriteVisitor in LibraryAnalyzer._resolveFile2 #33506

Closed
stereotype441 opened this issue Jun 19, 2018 · 2 comments
Closed

Find a replacement for AstRewriteVisitor in LibraryAnalyzer._resolveFile2 #33506

stereotype441 opened this issue Jun 19, 2018 · 2 comments
Assignees
@scheglov
Milestone
AnalyzerCFE

Comments

@stereotype441
Copy link
Member

The purpose of the AstRewriteVisitor is to rewrite things that look like method calls into things that look like constructor calls (to support implicit constructor calls). This visitor relies on resolution results, but we're calling it at a time that we haven't received resolution results yet. I'm hoping that the visitor can eventually go away completely, because in the final design, the front end will know whether we're looking at a constructor call when it calls the factory, and it will call the appropriate factory method.
@stereotype441 stereotype441 self-assigned this Jun 19, 2018
@scheglov scheglov mentioned this issue Jun 26, 2018
Closed
@JekCharlsonYu JekCharlsonYu added this to the AnalyzerCFE milestone Jun 27, 2018
@scheglov scheglov assigned scheglov and unassigned stereotype441 Aug 2, 2018
dart-bot pushed a commit that referenced this issue Aug 2, 2018
@scheglov
Issue 33506. Rewrite MethodInvocation into InstanceCreationExpression.
d618970 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I712ab3c79cfe29b2c201b0affc10b33fc0f60d15
Bug: #33506
Reviewed-on: https://dart-review.googlesource.com/68004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@scheglov
Copy link
Contributor

scheglov commented Aug 2, 2018 •
edited
Loading

Mostly done in https://dart-review.googlesource.com/c/sdk/+/68004
There is still a failing test because of using raw constructor element instead of Member.

The same or related problem also causes failing tests in (not yet uploaded) CL for verifying constants.

@scheglov
Copy link
Contributor

scheglov commented Aug 2, 2018

https://dart-review.googlesource.com/c/sdk/+/68161 will fix the ConstructorMember problem.

dart-bot pushed a commit that referenced this issue Aug 2, 2018
@scheglov
Translate ConstructorElement(s) of parameterized InterfaceType(s) to …
62a2752 
…ConstructorMember(s).

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I865a2e96f691d827165eabf382b5677d0831e831
Bug: #33506
Reviewed-on: https://dart-review.googlesource.com/68161
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
@scheglov scheglov closed this as completed Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
None yet
Projects
None yet
Milestone
AnalyzerCFE
Development

No branches or pull requests
4 participants
@stereotype441 @scheglov @anders-sandholm @JekCharlsonYu