New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flutter buildbot breakage #35187

Closed

liamappelbe opened this issue Nov 15, 2018 · 0 comments

Assignees

Contributor

liamappelbe commented Nov 15, 2018 •

edited

Loading

Breakage: https://luci-milo.appspot.com/buildbot/client.dart.internal/flutter-engine-linux/21794
Culprit: https://dart-review.googlesource.com/c/sdk/+/84542
Looks like I missed a build file. I'll send a CL soon.

liamappelbe self-assigned this

dart-bot pushed a commit that referenced this issue


          Quick fix for the flutter build.

d5145ad

Reverting the breaking part of
https://dart-review.googlesource.com/c/sdk/+/84542. I'll mail a proper
fix for this later.

Tested locally by building the flutter engine.

Bug: #35187
Change-Id: I1dbde39b4a8b437f711ad82c98790de87f28add5
Reviewed-on: https://dart-review.googlesource.com/c/84580
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

liamappelbe closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment