Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue for implementing experimental flags in the Dart VM #35602

Closed
a-siva opened this issue Jan 8, 2019 · 2 comments
Closed

Issue for implementing experimental flags in the Dart VM #35602

a-siva opened this issue Jan 8, 2019 · 2 comments
Assignees
@liamappelbe
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug

Comments

@a-siva
Copy link
Contributor

a-siva commented Jan 8, 2019

Reference:

Dart SDK Process for changes behind experimental flags

Dart Experimental Flags Implementation

This issue is opened to track the following

  • implementing the experimental flags option in the command line VM
  • hooking up the experimental flags options passed in to the CFE invoked in the kernel isolate
  • reading the options embedded in the kernel file and appropriately setting the VM flags
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug labels Jan 8, 2019
dart-bot pushed a commit that referenced this issue Jan 15, 2019
@liamappelbe
[VM] Experimental flags in the dart CLI
df0671d 
Blocked on https://dart-review.googlesource.com/c/sdk/+/88840

Bug: #35602
Change-Id: I72b1cf574c9cb3d1dac2fbd8dfeb0f3fd80e330e
Reviewed-on: https://dart-review.googlesource.com/c/89042
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
@liamappelbe
Copy link
Contributor

liamappelbe commented Jan 16, 2019 •
edited
Loading

Note to self: We also need to plumb this through in gen_kernel and (for tests) compiler_configuration.dart

dart-bot pushed a commit that referenced this issue Jan 23, 2019
@liamappelbe
[VM] Add experimental flags to gen_kernel.
c6e0d56 
Bug: #35602
Change-Id: I41cc7fcfe2ec520d4b6cf1d8e9535c618b09637d
Reviewed-on: https://dart-review.googlesource.com/c/90540
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
dart-bot pushed a commit that referenced this issue Jan 23, 2019
@liamappelbe
[VM] Add experimental flags to frontend_server.
c8e5e06 
Bug: #35602
Change-Id: Idd001a916f51c20d601c793c39d2a7752ed8f747
Reviewed-on: https://dart-review.googlesource.com/c/90503
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
dart-bot pushed a commit that referenced this issue Jan 25, 2019
@liamappelbe
[VM] Experimental flags in dartkp tests
c167cd3 
Plumb experimental flags found in a test's SharedOptions through to the
gen_kernel command invoked in dartkp tests. Also enable a whole bunch
of tests that are now passing.

Bug: #35602
Change-Id: I425f55ea6c84d28e085ab2c848376e396e68a225
Reviewed-on: https://dart-review.googlesource.com/c/90860
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
@liamappelbe
Copy link
Contributor

This issue is done, except for the last step of deserializing the flags from the kernel. The CFE currently doesn't serialize the flags because there's no experimental feature that needs a VM implementation yet. So deserialization will have to wait until there's a use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamappelbe liamappelbe

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liamappelbe @a-siva