Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standalone_2/io/arguments_test failing on vm-kernel-precomp #35960

Closed
whesse opened this issue Feb 15, 2019 · 1 comment
Closed

standalone_2/io/arguments_test failing on vm-kernel-precomp #35960

whesse opened this issue Feb 15, 2019 · 1 comment
Assignees
@sstrickl
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). gardening

Comments

@whesse
Copy link
Contributor

whesse commented Feb 15, 2019

The kernel-precomp test harness passes runtime arguments to the compiler instead of the runtime, so this test for runtime access to script arguments is failing until the harness is fixed.

This problem started with the commit of https://dart-review.googlesource.com/c/sdk/+/93302
and has a log at

https://dart-ci.appspot.com/log/vm-kernel-precomp-linux-debug-x64/latest/standalone_2/io/arguments_test

it fails on builders:

BOT TEST RESULT EXPECTED
vm-kernel-precomp-bare-linux-release-simarm standalone_2/io/arguments_test RuntimeError Pass
vm-kernel-precomp-bare-linux-release-simarm64 standalone_2/io/arguments_test RuntimeError Pass
vm-kernel-precomp-bare-linux-release-x64 standalone_2/io/arguments_test RuntimeError Pass
vm-kernel-precomp-linux-debug-x64 standalone_2/io/arguments_test RuntimeError Pass
vm-kernel-precomp-linux-product-x64 standalone_2/io/arguments_test RuntimeError Pass
vm-kernel-precomp-linux-release-simarm standalone_2/io/arguments_test RuntimeError Pass
vm-kernel-precomp-linux-release-simarm64 standalone_2/io/arguments_test RuntimeError Pass
vm-kernel-precomp-linux-release-x64 standalone_2/io/arguments_test RuntimeError Pass
vm-kernel-precomp-mac-release-simarm64 standalone_2/io/arguments_test RuntimeError Pass
vm-kernel-precomp-obfuscate-linux-release-x64 standalone_2/io/arguments_test RuntimeError Pass
vm-kernel-precomp-win-release-simarm64 standalone_2/io/arguments_test RuntimeError Pass
vm-kernel-precomp-win-release-x64 standalone_2/io/arguments_test RuntimeError Pass
@whesse whesse added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Feb 15, 2019
@whesse
Copy link
Contributor Author

whesse commented Feb 15, 2019

@dcharkes @mkustermann

@rmacnak-google rmacnak-google added area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). and removed area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Feb 19, 2019
@rmacnak-google rmacnak-google removed their assignment Feb 19, 2019
@sstrickl sstrickl self-assigned this Mar 25, 2019
dart-bot pushed a commit that referenced this issue Mar 25, 2019
@sstrickl
[gardening] Fix arguments test for app_jit(k).
ab8510a 
The fix for #35960 broke
on app_jit(k) runs, because these expect the arguments to be
passed when creating the jit snapshot. Pass dartOptions along to
computeCompilerArguments as well, so that the
AppJitCompilerConfiguration can add them in appropriately.

Change-Id: I8c7b5a3a1689943db4e6c3785ccaf8bfdb839c2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97516
Reviewed-by: Stevie Strickland <sstrickl@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sstrickl sstrickl

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sstrickl @dcharkes @whesse @rmacnak-google