Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum values not included in completion for LSP server #37472

Closed
DanTup opened this issue Jul 9, 2019 · 1 comment
Closed

Enum values not included in completion for LSP server #37472

DanTup opened this issue Jul 9, 2019 · 1 comment
Assignees
@DanTup
Labels
analyzer-lsp Issues with analysis server's support of Language Server Protocol area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.

Comments

@DanTup
Copy link
Collaborator

DanTup commented Jul 9, 2019

Normally we get enum values in completion:

Screenshot 2019-07-09 at 2 28 59 pm

However this doesn't seem to work in LSP:

Screenshot 2019-07-09 at 2 28 11 pm

Spotted while trying to apply the fix for Dart-Code/Dart-Code#1835 to LSP, but it didn't have the issue because the values aren't there.

(When fixing, we need to be sure it doesn't include that bug).
@DanTup DanTup self-assigned this Jul 9, 2019
@DanTup DanTup added analyzer-lsp Issues with analysis server's support of Language Server Protocol area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Jul 9, 2019
dart-bot pushed a commit that referenced this issue Jul 10, 2019
@DanTup
Add missing child declarations to LSP completion
e3d5966 
- Adds enum values
- Adds named constructors
- Avoids duplicates by using parent name for constructors/enums when checking against existing imports
- Adds parens to end of labels in completion text

Change-Id: Idab620326023a153c01c0ebd8349a2101dfae7b4
Bug: #37472
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108413
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
@DanTup
Copy link
Collaborator Author

DanTup commented Jul 18, 2019

Fixed by e3d5966.

@DanTup DanTup closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanTup DanTup

Labels
analyzer-lsp Issues with analysis server's support of Language Server Protocol area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanTup