Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2native has unneeded output #38524

Closed
mit-mit opened this issue Sep 23, 2019 · 1 comment
Closed

dart2native has unneeded output #38524

mit-mit opened this issue Sep 23, 2019 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-native

Comments

@mit-mit
Copy link
Member

mit-mit commented Sep 23, 2019

We currently produce a fair amount of status output:

$ dart2native hello.dart
Generating AOT kernel dill.
Generating AOT snapshot.
Generating executable.
Marking binary executable.
Generated: /Users/mit/tmp/hello.dart.exe
$

I suggest that we remove anything but the last line from the standard output. If there is a reason to keep it, I suggest we put it behind a -v, --verbose flag like other Dart commands.
@mit-mit mit-mit added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-native labels Sep 23, 2019
dart-bot pushed a commit that referenced this issue Sep 23, 2019
[SDK] Adds dart2native --verbose.
0b7a78d 
Bug: #38524, #38525
Change-Id: Ic950fcadd328d1adeae19dd1046270fe4f4320e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118387
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
@ghost ghost self-assigned this Sep 24, 2019
@ghost
Copy link

ghost commented Sep 24, 2019

This is now fixed in 0b7a78d.

@ghost ghost closed this as completed Sep 24, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-native
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mit-mit