Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ffi tests to flutter/flutter to ensure they are exercised on device mix that flutter tests on #39570

Open
mkustermann opened this issue Nov 28, 2019 · 4 comments
Open

Add ffi tests to flutter/flutter to ensure they are exercised on device mix that flutter tests on #39570

mkustermann opened this issue Nov 28, 2019 · 4 comments
Assignees
@dcharkes
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi

Comments

@mkustermann
Copy link
Member

We should add tests (or benchmarks, if only those run on devicelab) to flutter/flutter to ensure dart:ffi features work across devices which flutter lab tests on.

Most importantly, this will give us actual coverage for iPhones.

(I've already brought this up in #38718 (comment) before, though we haven't done anything about it afaik)
@mkustermann mkustermann added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi labels Nov 28, 2019
@mkustermann
Copy link
Member Author

Many months ago I've made flutter/flutter#46078 for flutter which would run a copy of our ffi test suite as a flutter app on flutter's device lab. Though there's disagreements about whether we can have a copy of the tests in flutter, the licensing, etc.

I don't have the cycles to continue down a more complicated path for that.

@mkustermann mkustermann removed their assignment Sep 25, 2020
@dcharkes
Copy link
Contributor

@athomas any progress on getting iOS devices on our own CQ? (Which would remove the requirement for us to test through Flutter.)

@dnfield
Copy link
Contributor

dnfield commented Oct 5, 2020

FWIW, firebase testlab supports iOS.

@dnfield
Copy link
Contributor

dnfield commented Oct 5, 2020

The main challenge there is code signing unfortunately.

dart-bot pushed a commit that referenced this issue Oct 28, 2020
@dcharkes
[vm/ffi] Fix prepare_flutter_bundle.dart
312a572 
It now includes /ffi_test_functions_generated.cc and prints
instructions on how to use the generated bundle.

This CL adds some TODOs and deletes the non-migrated copy that was in
the NNBD folder.

Finally, this CL disable a check that fails because of static linking
on iOS.

Issue #39570.

Change-Id: Ie85d92568bb95eaafd2991725a1a31cdecd246be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169402
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcharkes dcharkes

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dcharkes @mkustermann @dnfield