Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on Steel thread through fantasyland. #40570

Closed
aam opened this issue Feb 10, 2020 · 2 comments
Closed

Failures on Steel thread through fantasyland. #40570

aam opened this issue Feb 10, 2020 · 2 comments
Assignees
@jcollins-g
Labels
NNBD Issues related to NNBD Release

Comments

@aam
Copy link
Contributor

aam commented Feb 10, 2020

There are new test failures on Steel thread through fantasyland..

The tests

pkg/nnbd_migration/test/fantasyland/fantasy_workspace_test RuntimeError (expected Pass)

are failing on configurations

unittest-asserts-release-win
@aam aam added the NNBD Issues related to NNBD Release label Feb 10, 2020
@jcollins-g
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/135180

dart-bot pushed a commit that referenced this issue Feb 10, 2020
@jcollins-g
Fix windows bot failure due to missing path conversion.
96794c5 
Change-Id: I1bf12360ee3e45b89ccc4f045151f037450df093
Bug: #40570
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135180
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Auto-Submit: Janice Collins <jcollins@google.com>
@jcollins-g
Copy link
Contributor

This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcollins-g jcollins-g

Labels
NNBD Issues related to NNBD Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aam @jcollins-g