Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a beta channel formula to homebrew and update homebrew release tooling #40990

Closed
athomas opened this issue Mar 11, 2020 · 6 comments · Fixed by dart-lang/homebrew-dart#73
Closed

Add a beta channel formula to homebrew and update homebrew release tooling #40990

athomas opened this issue Mar 11, 2020 · 6 comments · Fixed by dart-lang/homebrew-dart#73
Assignees
@athomas
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.

Comments

@athomas
Copy link
Member

athomas commented Mar 11, 2020

No description provided.

@keertip keertip added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Mar 11, 2020
@athomas athomas changed the title Add a beta channel recipe to homebrew and update homebrew release tooling Add a beta channel formula to homebrew and update homebrew release tooling Mar 27, 2020
@athomas athomas self-assigned this Mar 27, 2020
dart-bot pushed a commit that referenced this issue Mar 27, 2020
@athomas
[homebrew] Add support for the beta channel formula
a96b4f6 
This changes to the homebrew tooling to modify instead of replace the
formulas. The formulas can now be changed by editing them in the
dart-lang/homebrew-dart repo, rather than in the release tooling.

Also adds a dry-run mode for local testing.

#40990

Change-Id: Ibed90894800e4d84fac3c4558e6f08d629baed62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141244
Reviewed-by: William Hesse <whesse@google.com>
@athomas athomas mentioned this issue Mar 27, 2020
Merged
@athomas
Copy link
Member Author

athomas commented Mar 30, 2020

For homebrew, there will be a new dart-beta package, this will work like this:

brew install dart # works as before
brew install dart-beta # fails, conflicts with dart
brew unlink dart # dart still installed, but no longer in the path
brew install dart-beta # works, dart-beta is now in the path

The dev version is installed with brew install dart --devel as before. The dart-beta package won't have an unstable version.

@athomas
Copy link
Member Author

athomas commented Apr 2, 2020

The new script doesn't update the version. This needs to be fixed as well.

@athomas athomas reopened this Apr 2, 2020
@athomas athomas mentioned this issue Apr 3, 2020
Closed
@johnpryan
Copy link
Contributor

Is the dev channel still installed using brew install dart -- --devel?

@athomas
Copy link
Member Author

athomas commented Apr 3, 2020 via email

dart-bot pushed a commit that referenced this issue Apr 14, 2020
@athomas
[homebrew] Modify the version string when updating the version
5a7aa05 
This is a follow-up to a96b4f6 which changed the script but introduced
the bug that it no longer updated the version string in the formula.

Fixes #40990.

Change-Id: I272d21d2c4a44161f697ba52da6bb74b1cc7c5f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142147
Reviewed-by: William Hesse <whesse@google.com>
@devoncarew
Copy link
Member

devoncarew commented May 10, 2020 •
edited
Loading

Yes, the dev channel should not be affected by this change.

I'm curious why we have separate formulas for dart and dart-beta? Could we have added a beta version to the dart formula, so it supported stable, beta, and dev?

golang does something lime that - they support stable, 'bottle', and head versions:

https://github.com/Homebrew/homebrew-core/blob/master/Formula/go.rb

@athomas
Copy link
Member Author

athomas commented May 11, 2020

My impression is that bottles are some sort of pre-builts for built-from-source packages rather than channel specific distributions.

But, if they can be used I still think the UX is better with a separate formula: The stable and dev channels map quite nicely on a single formula because there's brew install --devel to select the dev channel. Using bottles for beta would probably mean something like brew install --force-bottle=beta dart. brew install dart-beta is shorter and doesn't require any knowledge about bottles.

athomas added a commit to dart-lang/homebrew-dart that referenced this issue Jun 4, 2021
@athomas
[homebrew] Add support for the beta channel formula
26ad494 
This changes to the homebrew tooling to modify instead of replace the
formulas. The formulas can now be changed by editing them in the
dart-lang/homebrew-dart repo, rather than in the release tooling.

Also adds a dry-run mode for local testing.

dart-lang/sdk#40990

Change-Id: Ibed90894800e4d84fac3c4558e6f08d629baed62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141244
Reviewed-by: William Hesse <whesse@google.com>
athomas added a commit to dart-lang/homebrew-dart that referenced this issue Jun 4, 2021
@athomas
[homebrew] Modify the version string when updating the version
1dca21f 
This is a follow-up to a96b4f6 which changed the script but introduced
the bug that it no longer updated the version string in the formula.

Fixes dart-lang/sdk#40990.

Change-Id: I272d21d2c4a44161f697ba52da6bb74b1cc7c5f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142147
Reviewed-by: William Hesse <whesse@google.com>
athomas added a commit to dart-lang/homebrew-dart that referenced this issue Jul 1, 2021
@athomas
[homebrew] Add support for the beta channel formula
f217dde 
This changes to the homebrew tooling to modify instead of replace the
formulas. The formulas can now be changed by editing them in the
dart-lang/homebrew-dart repo, rather than in the release tooling.

Also adds a dry-run mode for local testing.

dart-lang/sdk#40990

Change-Id: Ibed90894800e4d84fac3c4558e6f08d629baed62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141244
Reviewed-by: William Hesse <whesse@google.com>
athomas added a commit to dart-lang/homebrew-dart that referenced this issue Jul 1, 2021
@athomas
[homebrew] Modify the version string when updating the version
7ab2e48 
This is a follow-up to a96b4f6 which changed the script but introduced
the bug that it no longer updated the version string in the formula.

Fixes dart-lang/sdk#40990.

Change-Id: I272d21d2c4a44161f697ba52da6bb74b1cc7c5f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142147
Reviewed-by: William Hesse <whesse@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athomas athomas

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add beta channel formula athomas/homebrew-dart
4 participants
@johnpryan @devoncarew @keertip @athomas