Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inspect metrics in the OS module for Fuchsia. #41525

Closed
filmil opened this issue Apr 15, 2020 · 2 comments
Closed

Add inspect metrics in the OS module for Fuchsia. #41525

filmil opened this issue Apr 15, 2020 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@filmil
Copy link
Contributor

filmil commented Apr 15, 2020

Adding inspect metrics in the OS module for fuchsia. This will make Fuchsia-specific
changes easier to diagnose in the future, as the inspect metrics will become available
in the bug reports.

This depends on issue #41523 being fixed and rolled out.
@filmil
Copy link
Contributor Author

filmil commented Apr 15, 2020

I'd like to work on this; please assign me to the issue.

@devoncarew devoncarew added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Apr 17, 2020
dart-bot pushed a commit that referenced this issue Apr 30, 2020
@filmil
Adds inspect to vm/os_fuchsia.cc
d2e4a3c 
This will allow introspection of the state of tzdata loader, making
error diagnostics easier on Fuchsia.

Must be merged only after this pull request is merged into flutter
flutter/engine#17876
Otherwise, the call to the `dart::ComponentContext()` could prevent
the runners from initializing the component context correctly.

Tested:
  Compiled and deployed on a Fuchsia device.
  The result on Fuchsia is as seen below.

```
$ fx iquery
/hub/c/flutter_jit_product_runner.cmx/21608/out/diagnostics:
  /hub/c/flutter_jit_product_runner.cmx/21608/out/diagnostics#os:
    dst_status = 0
    tz_data_close_status = 0
    tz_data_status = 0
```

See issue #41525 for details.

Bug: fuchsia:43341
Change-Id: I43ea289003e1e1d09cca4163236bc477eb9cee80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144480
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Filip Filmar <fmil@google.com>
@filmil
Copy link
Contributor Author

filmil commented Jul 22, 2020

This was fixed a while ago. See commit d2e4a3c.

@filmil filmil closed this as completed Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@filmil @devoncarew