Remove sdk or sdk_nnbd from stack traces in dart2js

[natebosch]

Before the unfork we got org-dartlang-sdk:///sdk/lib/, after the unfork we get org-dartlang-sdk:///sdk_nnbd/lib/. Instead of hardcoding sdk_nnbd for now, and then get broken again if/when that gets removes, we should consider switching to org-dartlang-sdk:///lib/. It's a minor breaking change for package:test but I think the only impact is a degraded UX around stack traces and upgrading to the latest test runner should be a viable fix for most users.

cc @grouma @jakemac53 in case there are any concerns about old versions of package test not working with newer SDKs for this.

[sigmundch]

Just to clarify, are you seeing this in dart2js, ddc, or both sdks?

[natebosch]

Only dart2js is causing our tests to fail. , and only when we build for node.

I'm not sure if we have the same behavior covered for DDC since we rely on build_runner for DDC and it's not tested in the package:test repo.

[jakemac53]

build_runner does have some stack trace tests of its own in the _test dir I am pretty sure. We should verify that those are passing but I haven't seen a failure. I think it just looks for org-dartlang-sdk scheme.

[sigmundch]

ok, we'd need to also investigate if there are downstream dependencies of this internally in our bazel integration

[sigmundch]

Actually we'll likely be able to change the external build without changing the internal one, so we may be able to treat this as a separate issue

[jakemac53]

Fwiw, here is the test code for the browser platform that breaks https://github.com/dart-lang/test/blob/master/pkgs/test/lib/src/runner/browser/platform.dart#L414. It is setting an sdk root of org-dartlang-sdk:///sdk.

So, we can't easily do anything compatible across multiple sdks other than setting it to org-dartlang-sdk:/// which will show sdk/sdk_nnbd in the path on some older sdks. I do think changing the root for the build itself to just above the lib dir is the correct choice though, assuming it makes org-dartlang-sdk paths be valid paths under the shipped sdk.

[sigmundch]

I created https://dart-review.googlesource.com/c/sdk/+/148881