Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New test nnbd failures on dartkp-strong-linux-release-x64 #42643

Closed
mkustermann opened this issue Jul 9, 2020 · 4 comments
Closed

New test nnbd failures on dartkp-strong-linux-release-x64 #42643

mkustermann opened this issue Jul 9, 2020 · 4 comments
Assignees
@crelier
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening NNBD Issues related to NNBD Release

Comments

@mkustermann
Copy link
Member

There are new test failures on [vm] Reify loading units....Add WorkspacePackage to each FileState..

The tests

co19/LanguageFeatures/nnbd/type-normalization/equations_A12_t01 Crash (expected Pass)
co19/LanguageFeatures/nnbd/type-normalization/norm_A02_t04 Crash (expected Pass)
co19/LanguageFeatures/nnbd/type-normalization/norm_A02_t05 Crash (expected Pass)
co19/LanguageFeatures/nnbd/type-normalization/norm_A02_t07 Crash (expected Pass)
co19/LanguageFeatures/nnbd/type-normalization/norm_A06_t10 Crash (expected Pass)

are failing on configurations

dartkp-strong-linux-release-x64

/cc @rmacnak-google @alexmarkov
@mkustermann mkustermann added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Jul 9, 2020
@alexmarkov
Copy link
Contributor

Failure log:

/======================================================================================================================================\
| dartkp-strong-linux-release-x64:co19/LanguageFeatures/nnbd/type-normalization/equations_A12_t01 broke (Pass -> Crash, expected Pass) |
\======================================================================================================================================/

--- Command "vm_compile_to_kernel []" (took 02.000862s):
DART_CONFIGURATION=ReleaseX64 /b/s/w/ir/pkg/vm/tool/gen_kernel --aot --platform=out/ReleaseX64/vm_platform_strong.dill -o /b/s/w/ir/out/ReleaseX64/generated_compilations/dartkp/tests_co19_src_LanguageFeatures_nnbd_type-normalization_equations_A12_t01/out.dill /b/s/w/ir/tests/co19/src/LanguageFeatures/nnbd/type-normalization/equations_A12_t01.dart --enable-experiment=non-nullable --packages=/b/s/w/ir/.packages -Ddart.vm.product=false -Ddart.developer.causal_async_stacks=true --null-safety

exit code:
0

--- Command "precompiler" (took 94ms):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/gen_snapshot --enable-experiment=non-nullable --snapshot-kind=app-aot-assembly --assembly=/b/s/w/ir/out/ReleaseX64/generated_compilations/dartkp/tests_co19_src_LanguageFeatures_nnbd_type-normalization_equations_A12_t01/out.S --null-safety --enable-experiment=non-nullable --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/out/ReleaseX64/generated_compilations/dartkp/tests_co19_src_LanguageFeatures_nnbd_type-normalization_equations_A12_t01/out.dill

exit code:
-6

stderr:
===== CRASH =====
si_signo=Segmentation fault(11), si_code=1, si_addr=0xaf
version=2.9.0-edge.d4ffb92ed8fb33d4a7597a513b4e5556d4439ed7 (be) (Thu Jul 9 00:15:07 2020 +0000) on "linux_x64"
pid=5723, thread=5723, isolate_group=isolate(0x564461a0e500), isolate=isolate(0x5644619fdb00)
isolate_instructions=0, vm_instructions=0
  pc 0x000056445f19d497 fp 0x00007ffd94aa1ce0 dart::Type::IsInstantiated(dart::Genericity, long, dart::ZoneGrowableHandlePtrArray<dart::AbstractType const>*) const+0x127
  pc 0x000056445f19d29b fp 0x00007ffd94aa1d00 dart::Type::SetIsFinalized() const+0x1b
  pc 0x000056445f19b98b fp 0x00007ffd94aa1d40 dart::AbstractType::NormalizeFutureOrType(dart::Heap::Space) const+0x17b
  pc 0x000056445f655bc3 fp 0x00007ffd94aa1d80 dart::kernel::TypeTranslator::BuildInterfaceType(bool)+0x323
  pc 0x000056445f656b68 fp 0x00007ffd94aa1db0 dart::kernel::TypeTranslator::BuildTypeArguments(long)+0x98
  pc 0x000056445f655b38 fp 0x00007ffd94aa1df0 dart::kernel::TypeTranslator::BuildInterfaceType(bool)+0x298
  pc 0x000056445f65587d fp 0x00007ffd94aa1e10 dart::kernel::TypeTranslator::BuildTypeWithoutFinalization()+0x1d
  pc 0x000056445f13f9b1 fp 0x00007ffd94aa1e60 dart::kernel::KernelLoader::LoadPreliminaryClass(dart::kernel::ClassHelper*, long)+0x71
  pc 0x000056445f13ddf1 fp 0x00007ffd94aa1f90 dart::kernel::KernelLoader::LoadClass(dart::Library const&, dart::Class const&, long, dart::Class*)+0x2e1
  pc 0x000056445f13c635 fp 0x00007ffd94aa20b0 dart::kernel::KernelLoader::LoadLibrary(long)+0x555
  pc 0x000056445f13a97b fp 0x00007ffd94aa21e0 dart::kernel::KernelLoader::LoadProgram(bool)+0x14b
  pc 0x000056445f06b2c6 fp 0x00007ffd94aa26d0 out/ReleaseX64/gen_snapshot+0x5a02c6
  pc 0x000056445f06ae31 fp 0x00007ffd94aa2760 dart::Bootstrap::DoBootstrapping(unsigned char const*, long)+0x281
  pc 0x000056445f15c620 fp 0x00007ffd94aa2870 dart::Object::Init(dart::Isolate*, unsigned char const*, long)+0xc010
  pc 0x000056445f0d10f6 fp 0x00007ffd94aa2930 dart::Dart::InitIsolateFromSnapshot(dart::Thread*, dart::Isolate*, unsigned char const*, unsigned char const*, unsigned char const*, long)+0x46
  pc 0x000056445f0d15a6 fp 0x00007ffd94aa2a10 dart::Dart::InitializeIsolate(unsigned char const*, unsigned char const*, unsigned char const*, long, dart::IsolateGroup*, void*)+0xc6
  pc 0x000056445f68f7dd fp 0x00007ffd94aa2ab0 out/ReleaseX64/gen_snapshot+0xbc47dd
  pc 0x000056445f690143 fp 0x00007ffd94aa2b90 Dart_CreateIsolateGroupFromKernel+0x1c3
  pc 0x000056445f01e98c fp 0x00007ffd94aa2d20 dart::bin::main(int, char**)+0x70c
-- End of DumpStackTrace

--- Re-run this test:
python tools/test.py -n dartkp-strong-linux-release-x64 co19/LanguageFeatures/nnbd/type-normalization/equations_A12_t01

@alexmarkov alexmarkov added the NNBD Issues related to NNBD Release label Jul 9, 2020
@alexmarkov
Copy link
Contributor

/cc @crelier

@crelier crelier self-assigned this Jul 9, 2020
@crelier
Copy link
Contributor

crelier commented Jul 9, 2020

Class Future is needed for type normalization but is not yet cached in the object store.
CL https://dart-review.googlesource.com/c/sdk/+/153901 resolves the class on the fly when not yet cached.

@crelier
Copy link
Contributor

crelier commented Jul 14, 2020

Fixed by https://dart-review.googlesource.com/c/sdk/+/153901

@crelier crelier closed this as completed Jul 14, 2020
dart-bot pushed a commit that referenced this issue Jul 14, 2020
@crelier
[VM/nnbd] Class Future may be used for type normalization before it i…
994c6ba 
…s cached in the object store.

Class Future is resolved on the fly if not already cached.
Note that postponing type normalization until type finalization does not help
and results in the same error.

Fixes issue #42643

Change-Id: Id4dbeba6a246dbc952cce4168a10137a49d3ce70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153901
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crelier crelier

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening NNBD Issues related to NNBD Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkustermann @crelier @alexmarkov