Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer fails to report illegal use of @visibleForTesting top-level variables #43508

Closed
srawlins opened this issue Sep 21, 2020 · 0 comments
Closed

Analyzer fails to report illegal use of @visibleForTesting top-level variables #43508

srawlins opened this issue Sep 21, 2020 · 0 comments
Assignees
@srawlins
Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@srawlins
Copy link
Member

Also @visibleForTemplate
@srawlins srawlins self-assigned this Sep 21, 2020
@srawlins srawlins added analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Sep 21, 2020
dart-bot pushed a commit that referenced this issue Sep 21, 2020
@srawlins
analyzer_cli: Remove @VisibleForTesting from two sinks used outside t…
86169a1 
…ests

These two sinks are used in more than a dozen places in
analyzer_cli/lib/src/options.dart, so I think the annotations should
just be removed. The analyzer has a bug which prevented these top-level
getters from being reported.

#43508

Change-Id: Id4c1964a7181ea0aaf695ec8b49534243c269c20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163682
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
@srawlins srawlins mentioned this issue Oct 13, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
analyzer-warning Issues with the analyzer's Warning codes area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srawlins