Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No line breaking on explanatory NNBD text #43924

Closed
timsneath opened this issue Oct 26, 2020 · 1 comment
Closed

No line breaking on explanatory NNBD text #43924

timsneath opened this issue Oct 26, 2020 · 1 comment
Assignees
@srawlins
Labels
area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). P2 A bug or feature request we're likely to work on

Comments

@timsneath
Copy link
Contributor

See note below:

 $ dart migrate
Migrating /Users/timsneath/git/me/news

Note: this tool is currently running on an SDK version where null safety is not yet enabled by default. You may encounter issues in the migration process - some aspects of the toolchain assume that they are running on an SDK where null safety has been enabled by default.

See https://dart.dev/go/null-safety-migration for a migration guide.

We should word wrap the text here:

sdk/pkg/nnbd_migration/lib/migration_cli.dart

Line 261 in 4316601

String get description => nullSafetyOnByDefault

@vsmenon vsmenon added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Oct 27, 2020
@srawlins srawlins added the P2 A bug or feature request we're likely to work on label Oct 27, 2020
@srawlins srawlins self-assigned this Oct 27, 2020
dart-bot pushed a commit that referenced this issue Oct 27, 2020
@devoncarew
Remove a message for pre-nnbd sdks.
dac61ff 
Bug: #43924
Change-Id: I900f03ebf67f9b4fe5bb9277555293d03295a34c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169241
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
@srawlins
Copy link
Member

Most long textual messages the tool writes are wrapped. This one message referenced above was just removed.

@stereotype441 stereotype441 added area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). and removed analyzer-nnbd-migration area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srawlins @stereotype441 @vsmenon @timsneath