Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data race on dart::Thread::task_kind() #44304

Closed
dcharkes opened this issue Nov 24, 2020 · 0 comments
Closed

Data race on dart::Thread::task_kind() #44304

dcharkes opened this issue Nov 24, 2020 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@dcharkes
Copy link
Contributor 

SUMMARY: ThreadSanitizer: data race ../../out/ReleaseTSANX64/../../runtime/vm/thread.h:370 in dart::Thread::task_kind() const
==================
ThreadSanitizer: reported 3 warnings

--- Re-run this test:
python tools/test.py -n dartk-tsan-linux-release-x64 vm/cc/Service_IsolateStickyError

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8862958380763024864/+/steps/test_results/0/logs/ignored_flaky_test_failure_logs/0
@dcharkes dcharkes added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Nov 24, 2020
dart-bot pushed a commit that referenced this issue Dec 8, 2020
@rmacnak-google
[vm, service] Remove unsafe querying across threads during Isolate::P…
e3a9d70 
…rintJSON.

Note this would be unsafe even if under a safepoint operation because not all of the queried threads participate in safepoints.

TEST=tsan
Bug: #44304
Bug: #44385
Change-Id: I8156e8c6049165e5c53b66c3391f3e8a496ddaaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175000
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcharkes @rmacnak-google