Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Migration] Fix disabled tests #44522

Open
scheglov opened this issue Dec 21, 2020 · 2 comments
Open

[Migration] Fix disabled tests #44522

scheglov opened this issue Dec 21, 2020 · 2 comments
Assignees
@scheglov
Labels
analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@scheglov
Copy link
Contributor

This should be tests that are written in a more unit like fashion, and don't always set all expected nodes, elements, and types.
@scheglov scheglov added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on analyzer-technical-debt labels Dec 21, 2020
@scheglov scheglov self-assigned this Dec 21, 2020
@scheglov scheglov changed the title Fix tests disabled during package:analyzer migration [Migration] Fix disabled tests Jan 16, 2021
copybara-service bot pushed a commit that referenced this issue Dec 16, 2021
@stereotype441
Rewrite element resolver tests using the new PubPackageResolutionTest…
64939f5 
… style.

Using this style makes the tests more robust to refactoring the
analyzer, since the tests exercise the analyzer in end-to-end fashion.

Change-Id: I7038e542109cb6556f3db190d7a0e527f32e1788
Bug: #44522
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
copybara-service bot pushed a commit that referenced this issue Jan 4, 2022
@stereotype441
Rewrite static type analyzer tests using the new PubPackageResolution…
d48e475 
…Test style.

Using this style makes the tests more robust to refactoring the
analyzer, since the tests exercise the analyzer in end-to-end fashion.

Bug: #44522
Change-Id: Ia036d5d32621019841b5a5cf44f43ab8761f98aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224621
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
@srawlins
Copy link
Member

Hi @scheglov , do you know if the relevent tests are fixed? You don't mention which they are.

@scheglov
Copy link
Contributor Author

Yeah, I guess there were many of them while I was migrating the analyzer.
Search for 44522 in the analyzer.
We still have a few.

@srawlins srawlins added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srawlins @scheglov