Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart compiler should offer suppression of info messages #44727

Closed
timsneath opened this issue Jan 21, 2021 · 10 comments
Closed

Dart compiler should offer suppression of info messages #44727

timsneath opened this issue Jan 21, 2021 · 10 comments
Assignees
@johnniwinther @bkonyi
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Milestone
January Beta Rele...

Comments

@timsneath
Copy link
Contributor

We should suppress the output when the compile isn't something the user asked for - e.g. where running any flutter command requires compiling flutter_tools. This could be done e.g. with an undocumented --silent flag that can be used by Flutter.

See flutter/flutter#74366 for the current output.
@timsneath timsneath mentioned this issue Jan 21, 2021
Closed
@timsneath
Copy link
Contributor Author

@mit-mit to make sure this lands, given the tight timescale for the next beta cut-off.

@mit-mit
Copy link
Member

mit-mit commented Jan 22, 2021

@johnniwinther is looking at adding a new verbosity option to the CFE, after that we'll need a flag in the VM to pass on that option, cc @bkonyi

@mit-mit mit-mit added this to the January Beta Release (2.12) milestone Jan 22, 2021
@mit-mit mit-mit changed the title Dart compiler should offer suppression of null safety info message Dart compiler should offer suppression of info messages Jan 22, 2021
@johnniwinther
Copy link
Member

The plan is to add a --verbosity option with values error, warning, info, and all similar to dart-lang/pub@97555de with the default value all.

@mit-mit Do you agree?

@mit-mit
Copy link
Member

mit-mit commented Jan 22, 2021

sgtm!

@johnniwinther johnniwinther mentioned this issue Jan 22, 2021
Closed
@vsmenon vsmenon added the P2 A bug or feature request we're likely to work on label Jan 22, 2021
@vsmenon
Copy link
Member

vsmenon commented Jan 22, 2021

Marking as a P2.

What's the expected timeline for a fix? It'd be nice to get this in pre cut, but I don't think we need to block. It should be a low risk cherry pick if needed. FYI - @franklinyow

@johnniwinther
Copy link
Member

I expect to have CL for the CFE implementation ready today. This includes handling of the dart compile js, dart compile exe and dart compile aot-snapshot commands.

@johnniwinther
Copy link
Member

The CFE CL is in the pipeline: https://dart-review.googlesource.com/c/sdk/+/180566

@franklinyow franklinyow added area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). type-enhancement A request for a change that isn't a bug labels Jan 22, 2021
@johnniwinther
Copy link
Member

The CFE CL has landed.

dart-bot pushed a commit that referenced this issue Jan 22, 2021
@johnniwinther
[cfe,dartdev,dart2js] Add support for --verbosity option
97a4280 
In response to #44727

TEST=pkg/dartdev/test/commands/compile_test.dart

Change-Id: I56b67d9362a415acd721c1cce2f7e2232d2493df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180566
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
@johnniwinther johnniwinther mentioned this issue Jan 22, 2021
Closed
@bkonyi
Copy link
Contributor

bkonyi commented Jan 22, 2021

VM CL up for review: https://dart-review.googlesource.com/c/sdk/+/180605

@franklinyow
Copy link
Contributor

Any update on this? Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

@bkonyi bkonyi

Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
January Beta Release (2.12)
Development

No branches or pull requests
6 participants
@vsmenon @timsneath @johnniwinther @mit-mit @bkonyi @franklinyow