Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null check failed in ElementImpl.session #44837

Closed
scheglov opened this issue Feb 2, 2021 · 1 comment
Closed

Null check failed in ElementImpl.session #44837

scheglov opened this issue Feb 2, 2021 · 1 comment
Assignees
@scheglov
Labels
analyzer-crash-report Issues which have been reported due to an analysis server crash area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@scheglov
Copy link
Contributor

scheglov commented Feb 2, 2021 

Thread 0 main thread_CastError: Null check operator used on a null value
at ElementImpl.session(element.dart:2911)
at Member.session(member.dart:564)
at EditDomainHandler._getAvailableRefactoringsImpl(edit_domain.dart:850)

Fix: https://dart-review.googlesource.com/c/sdk/+/182362
@scheglov scheglov self-assigned this Feb 2, 2021
@scheglov scheglov added analyzer-crash-report Issues which have been reported due to an analysis server crash area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 2, 2021
@scheglov
Copy link
Contributor Author

scheglov commented Feb 2, 2021

Fixed in 977f171.

@scheglov scheglov closed this as completed Feb 2, 2021
dart-bot pushed a commit that referenced this issue Feb 4, 2021
@scheglov
Element.session can be nullable
9cbe1ca 
This is not convenient, and not nice, but it can be.
We have to accept that it can for now, and plan to make it better.

Bug: #44837
Change-Id: Icbd2d55b6690ed817b38a7768198c41ce36cf002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182960
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
analyzer-crash-report Issues which have been reported due to an analysis server crash area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scheglov