Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/vm_snapshot_analysis/test/instruction_sizes_test fails with RuntimeError on Windows #45354

Closed
alexmarkov opened this issue Mar 17, 2021 · 1 comment
Closed

pkg/vm_snapshot_analysis/test/instruction_sizes_test fails with RuntimeError on Windows #45354

alexmarkov opened this issue Mar 17, 2021 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@alexmarkov
Copy link
Contributor

The test

pkg/vm_snapshot_analysis/test/instruction_sizes_test RuntimeError (expected Pass)

is failing on configuration

unittest-asserts-release-win

Log:

--- Command "vm" (took 01:56.000546s):
set DART_CONFIGURATION=ReleaseX64 & set DART_SUPPRESS_WER=1 & set CHROME_PATH=C:\b\s\w\ir\cache\builder\sdk\third_party\browsers\chrome\Chrome\Application\chrome.exe & out\ReleaseX64\dart-sdk\bin\dart.exe --enable_asserts --ignore-unrecognized-flags --packages=C:\b\s\w\ir\cache\builder\sdk\.packages C:\b\s\w\ir\cache\builder\sdk\pkg\vm_snapshot_analysis\test\instruction_sizes_test.dart

exit code:
255

stdout:
00:00 �[32m+0�[0m: no-size-impact --print_instructions_sizes_to�[0m

00:16 �[32m+1�[0m: no-size-impact --write_v8_snapshot_profile_to�[0m

00:26 �[32m+2�[0m: instruction-sizes basic-parsing�[0m

00:31 �[32m+3�[0m: instruction-sizes program-info-from-sizes�[0m

00:36 �[32m+4�[0m: instruction-sizes histograms�[0m

00:41 �[32m+5�[0m: instruction-sizes diff�[0m

00:51 �[32m+6�[0m: instruction-sizes diff-collapsed�[0m

01:00 �[32m+7�[0m: v8-profile program-info-from-profile�[0m

01:05 �[32m+8�[0m: v8-profile instruction ownership is preserved�[0m

01:15 �[32m+9�[0m: v8-profile histograms�[0m

01:20 �[32m+10�[0m: v8-profile diff�[0m

01:30 �[32m+11�[0m: v8-profile diff-collapsed�[0m

01:40 �[32m+12�[0m: v8-profile treemap�[0m

01:45 �[32m+12�[0m�[31m -1�[0m: v8-profile treemap �[1m�[31m[E]�[0m�[0m

  Expected: not null
    Actual: <null>
  

  package:test_api/src/frontend/expect.dart 153:31                  fail
  package:test_api/src/frontend/expect.dart 148:3                   _expect
  package:test_api/src/frontend/expect.dart 57:3                    expect
  pkg\vm_snapshot_analysis\test\instruction_sizes_test.dart 736:11  main.<fn>.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1294:19                                      _CustomZone.registerBinaryCallback
  dart:async-patch/async_patch.dart 61:8                            _asyncErrorWrapperHelper
  package:test_api/src/backend/invoker.dart                         Invoker.waitForOutstandingCallbacks.<fn>
  dart:async/zone.dart 1354:13                                      _rootRun
  dart:async/zone.dart 1258:19                                      _CustomZone.run
  dart:async/zone.dart 1789:10                                      _runZoned
  dart:async/zone.dart 1711:10                                      runZoned
  package:test_api/src/backend/invoker.dart 228:5                   Invoker.waitForOutstandingCallbacks
  package:test_api/src/backend/invoker.dart 383:17                  Invoker._onRun.<fn>.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1286:19                                      _CustomZone.registerUnaryCallback
  dart:async-patch/async_patch.dart 45:22                           _asyncThenWrapperHelper
  package:test_api/src/backend/invoker.dart                         Invoker._onRun.<fn>.<fn>.<fn>
  dart:async/zone.dart 1354:13                                      _rootRun
  dart:async/zone.dart 1258:19                                      _CustomZone.run
  dart:async/zone.dart 1789:10                                      _runZoned
  dart:async/zone.dart 1711:10                                      runZoned
  package:test_api/src/backend/invoker.dart 370:9                   Invoker._onRun.<fn>.<fn>
  package:test_api/src/backend/invoker.dart 415:15                  Invoker._guardIfGuarded
  package:test_api/src/backend/invoker.dart 369:7                   Invoker._onRun.<fn>
  package:stack_trace/src/chain.dart 94:24                          Chain.capture.<fn>
  dart:async/zone.dart 1354:13                                      _rootRun
  dart:async/zone.dart 1258:19                                      _CustomZone.run
  dart:async/zone.dart 1789:10                                      _runZoned
  dart:async/zone.dart 1711:10                                      runZoned
  package:stack_trace/src/chain.dart 92:12                          Chain.capture
  package:test_api/src/backend/invoker.dart 368:11                  Invoker._onRun
  package:test_api/src/backend/live_test_controller.dart 153:11     LiveTestController.run
  dart:async/future.dart 198:37                                     new Future.microtask.<fn>
  dart:async/zone.dart 1346:47                                      _rootRun
  dart:async/zone.dart 1258:19                                      _CustomZone.run
  dart:async/zone.dart 1162:7                                       _CustomZone.runGuarded
  dart:async/zone.dart 1202:23                                      _CustomZone.bindCallbackGuarded.<fn>
  dart:async/zone.dart 1354:13                                      _rootRun
  dart:async/zone.dart 1258:19                                      _CustomZone.run
  dart:async/zone.dart 1162:7                                       _CustomZone.runGuarded
  dart:async/zone.dart 1202:23                                      _CustomZone.bindCallbackGuarded.<fn>
  dart:async/schedule_microtask.dart 40:21                          _microtaskLoop
  dart:async/schedule_microtask.dart 49:5                           _startMicrotaskLoop
  dart:isolate-patch/isolate_patch.dart 120:13                      _runPendingImmediateCallback
  dart:isolate-patch/timer_impl.dart 402:11                         _Timer._runTimers
  dart:isolate-patch/timer_impl.dart 426:5                          _Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 184:12                      _RawReceivePortImpl._handleMessage
  

01:45 �[32m+12�[0m�[31m -1�[0m: v8-profile dominators�[0m

01:51 �[32m+13�[0m�[31m -1�[0m: �[31mSome tests failed.�[0m

stderr:
Unhandled exception:
Dummy exception to set exit code.

--- Re-run this test:
python tools/test.py -n unittest-asserts-release-win pkg/vm_snapshot_analysis/test/instruction_sizes_test

This test became flaky around 4e1c79d, and then it has been flipping between RuntimeError and Timeout recently.

/cc @sstrickl @mraleph
@alexmarkov alexmarkov added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Mar 17, 2021
@alexmarkov
Copy link
Contributor Author

pkg/vm_snapshot_analysis/test/instruction_sizes_test turned from flaky to RuntimeError once again on Windows:

--- Command "vm" (took 01:40.000821s):
set DART_CONFIGURATION=ReleaseX64 & set DART_SUPPRESS_WER=1 & set CHROME_PATH=C:\b\s\w\ir\cache\builder\sdk\third_party\browsers\chrome\Chrome\Application\chrome.exe & out\ReleaseX64\dart-sdk\bin\dart.exe --enable_asserts --ignore-unrecognized-flags --packages=C:\b\s\w\ir\cache\builder\sdk\.packages C:\b\s\w\ir\cache\builder\sdk\pkg\vm_snapshot_analysis\test\instruction_sizes_test.dart

exit code:
255

stdout:
00:00 �[32m+0�[0m: no-size-impact --print_instructions_sizes_to�[0m

00:12 �[32m+1�[0m: no-size-impact --write_v8_snapshot_profile_to�[0m

00:20 �[32m+2�[0m: instruction-sizes basic-parsing�[0m

00:24 �[32m+3�[0m: instruction-sizes program-info-from-sizes�[0m

00:28 �[32m+4�[0m: instruction-sizes histograms�[0m

00:32 �[32m+5�[0m: instruction-sizes histograms-filter�[0m

00:36 �[32m+6�[0m: instruction-sizes diff�[0m

00:44 �[32m+7�[0m: instruction-sizes diff-collapsed�[0m

00:52 �[32m+8�[0m: v8-profile program-info-from-profile�[0m

00:57 �[32m+9�[0m: v8-profile instruction ownership is preserved�[0m

01:05 �[32m+10�[0m: v8-profile histograms�[0m

01:09 �[32m+11�[0m: v8-profile diff�[0m

01:18 �[32m+12�[0m: v8-profile diff-collapsed�[0m

01:26 �[32m+13�[0m: v8-profile treemap�[0m

01:30 �[32m+13�[0m�[31m -1�[0m: v8-profile treemap �[1m�[31m[E]�[0m�[0m

  Expected: not null
    Actual: <null>
  

  package:test_api/src/expect/expect.dart 137:31                    fail
  package:test_api/src/expect/expect.dart 132:3                     _expect
  package:test_api/src/expect/expect.dart 46:3                      expect
  pkg\vm_snapshot_analysis\test\instruction_sizes_test.dart 865:11  main.<fn>.<fn>.<fn>
  ===== asynchronous gap ===========================
  pkg\vm_snapshot_analysis\test\utils.dart 89:5                     withFlagImpl.<fn>
  ===== asynchronous gap ===========================
  pkg\vm_snapshot_analysis\test\utils.dart 100:5                    withTempDir
  ===== asynchronous gap ===========================
  pkg\vm_snapshot_analysis\test\instruction_sizes_test.dart 839:7   main.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 199:9                  Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 197:7                  Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 257:7                   Invoker._waitForOutstandingCallbacks.<fn>
  

Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
For example, 'pub run test --chain-stack-traces'.
01:31 �[32m+13�[0m�[31m -1�[0m: v8-profile dominators�[0m

01:35 �[32m+14�[0m�[31m -1�[0m: �[31mSome tests failed.�[0m

stderr:
Unhandled exception:
Dummy exception to set exit code.

--- Re-run this test:
python3 tools/test.py -n unittest-asserts-release-win pkg/vm_snapshot_analysis/test/instruction_sizes_test

https://dart-ci.appspot.com/log/pkg-win-release/unittest-asserts-release-win/16683/pkg/vm_snapshot_analysis/test/instruction_sizes_test

copybara-service bot pushed a commit that referenced this issue Nov 3, 2022
@aam
[gardening] Fix instruction_sizes_test on Windows
4ae1500 
Bug: #45354
Change-Id: Idbf22076bf01e9dcbe20a6d99993b3283edc067f
TEST=ci
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267244
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
@aam aam closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aam @alexmarkov