Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [vm] Handle WSRs more generally in v8 snapshot profile writing. #45702

Closed
sstrickl opened this issue Apr 14, 2021 · 5 comments
Closed

Failures on [vm] Handle WSRs more generally in v8 snapshot profile writing. #45702

sstrickl opened this issue Apr 14, 2021 · 5 comments
Assignees
@sstrickl
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@sstrickl
Copy link
Contributor

There are new test failures on [vm] Handle WSRs more generally in v8 snapshot profile writing..

The tests

ffi_2/function_callbacks_test/8 Crash (expected Pass)
language_2/deferred/split_constants_canonicalization_test/0 Crash (expected Pass)
vm/dart_2/causal_stacks/async_throws_stack_lazy_non_symbolic_test Crash (expected Pass)
vm/dart_2/deferred_loading_call_modes_test/0 Crash (expected Pass)
vm/dart_2/deferred_loading_call_modes_test/1 Crash (expected Pass)
vm/dart_2/split_literals_test/object RuntimeError (expected Pass)
vm/dart_2/v8_snapshot_profile_writer_test RuntimeError (expected Pass)

are failing on configurations

dartkp-linux-debug-simarm-crossword
dartkp-linux-debug-x64

Approving these temporarily, looking into the failure now.
@sstrickl sstrickl added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Apr 14, 2021
@sstrickl sstrickl self-assigned this Apr 14, 2021
@alexmarkov
Copy link
Contributor

These tests are also failing on the following NNBD configurations:

dartkp-strong-linux-debug-simarm-crossword
dartkp-strong-linux-debug-x64
dartkp-weak-asserts-linux-debug-x64
dartkp-weak-asserts-linux-debug-simarm-crossword

@sstrickl If there's no quick fix available, does it make sense to revert the change which caused these failures?

@sstrickl
Copy link
Contributor Author

sstrickl commented Apr 15, 2021 •
edited
Loading

Only AOT tests that don't have a dispatch table but go through WriteDispatchTable will be affected, which only seems like a handful of tests that turn on flags not usually used in practice.

I have had a quick fix ready for it in CL 195272, but unfortunately that is failing on x64c for some reason, which I am investigating and is proving harder to track down than I expected. I'm wondering whether to bother @rmacnak-google about it and see if he can find what's going on, because it looks like just weird corruption in compressed mode.

@rmacnak-google
Copy link
Contributor

You can land your change and leave x64c broken to make some progress. I'll take a look at x64c next week.

@sstrickl
Copy link
Contributor Author

Okay, have approved the failure on dartk-linux-debug-x64c (I assume it will fail on other debug-x64c configs so will approve post-landing.) and am submitting it now.

dart-bot pushed a commit that referenced this issue Apr 16, 2021
@sstrickl
Revert "[vm] Fix V8 snapshot profile handling of the dispatch table."
3fdecfc 
This reverts commit 5909fd1.

Reason for revert: Ended up breaking tests on non-x64c as well, investigating.

Original change's description:
> [vm] Fix V8 snapshot profile handling of the dispatch table.
>
> Fixes #45702.
>
> TEST=Tests listed in the issue above.
>
> Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try
> Change-Id: Ibf5e3ccf3828c01f9dda47de360314dabe8cb8a9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195272
> Reviewed-by: Daco Harkes <dacoharkes@google.com>
> Commit-Queue: Tess Strickland <sstrickl@google.com>

TBR=rmacnak@google.com,dacoharkes@google.com,sstrickl@google.com

Change-Id: I61d0eb217e7be04a0841fb9e7dddd180e31bed2a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195512
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
@sstrickl sstrickl reopened this Apr 16, 2021
@sstrickl
Copy link
Contributor Author

Fix did show issues on other builders as well. Product makes sense, as dropped Code objects weren't handled in CreateArtificalNodeIfNeeded (fixing that now). Hoping that one of the other bots, if not the same issue, also show what was going on with x64c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sstrickl sstrickl

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sstrickl @rmacnak-google @alexmarkov