Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quick fix for avoid_returning_null_for_void #45920

Closed
Tracked by #45932
bwilkerson opened this issue May 5, 2021 · 1 comment
Closed
Tracked by #45932

Add quick fix for avoid_returning_null_for_void #45920

bwilkerson opened this issue May 5, 2021 · 1 comment
Assignees
@bwilkerson
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on

Comments

@bwilkerson
Copy link
Member

The fix should remove the null (and preceding space).
@bwilkerson bwilkerson mentioned this issue May 5, 2021
Closed
14 tasks
@mit-mit mit-mit added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label May 6, 2021
@devoncarew devoncarew added the P2 A bug or feature request we're likely to work on label May 7, 2021
@bwilkerson bwilkerson mentioned this issue May 19, 2021
Closed
@bwilkerson bwilkerson self-assigned this May 22, 2021
@bwilkerson
Copy link
Member Author

https://dart-review.googlesource.com/c/sdk/+/201102

copybara-service bot pushed a commit that referenced this issue Dec 1, 2022
@oprypin
Expand RemoveReturnedValue fix to turn => null into {}
328c261 
This is targeted at the lint `avoid_returning_null_for_void` which already complains about expression function bodies but the fix doesn't do anything for them.

Change-Id: I14f3d7659301edae08482d9ffa6b72b483737e59
Bug: #45920
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Oleh Prypin <oprypin@google.com>
Commit-Queue: Oleh Prypin <oprypin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwilkerson bwilkerson

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devoncarew @bwilkerson @mit-mit