Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare package:wasm for publishing #45967

Closed
mit-mit opened this issue May 10, 2021 · 1 comment
Closed

Prepare package:wasm for publishing #45967

mit-mit opened this issue May 10, 2021 · 1 comment
Assignees
@liamappelbe
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@mit-mit
Copy link
Member

mit-mit commented May 10, 2021 •
edited
Loading

The pubspec has a few issues:

  1. Says "not for publishing"
  2. SDK constraint should be ">=2.10.0 <3.0.0"
  3. ffi dep should be rolled to ^1.0.0
  4. dev_dep om pedantic is missing

The readme.md file should have some contents. Can we provide a very small set of steps for for example calling into a hello world-like piece of C code or something like that?
@mit-mit mit-mit added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label May 10, 2021
@liamappelbe
Copy link
Contributor

I should also move the unit tests into this directory

dart-bot pushed a commit that referenced this issue May 20, 2021
@liamappelbe
[wasm] Prepare for release
96bb78a 
- Update pubspec and readme.
- Copy the setup.dart output directory logic from package:webcrypto
- Work around NPE in IsFfiCompound (see https://dart-review.googlesource.com/c/sdk/+/199602)
- Move all the wasm tests into the pkg/wasm directory

Bug: #45967
Change-Id: I467eb5401c9dfc94c2c6771e79a3da24459c9691
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199368
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamappelbe liamappelbe

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liamappelbe @mit-mit