Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gardening] Could not find a command named <...>.out.jitsnapshot #46125

Closed
dcharkes opened this issue May 25, 2021 · 2 comments
Closed

[gardening] Could not find a command named <...>.out.jitsnapshot #46125

dcharkes opened this issue May 25, 2021 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening library-ffi

Comments

@dcharkes
Copy link
Contributor

dcharkes commented May 25, 2021

Unexpected exit code 64
DART_CONFIGURATION=DebugX64 out/DebugX64/dart --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/out/DebugX64/generated_compilations/app_jitk-linux-debug-x64/multitest_ffi_2_vmspecific_leaf_call_test_02/out.jitsnapshot

Could not find a command named "/b/s/w/ir/out/DebugX64/generated_compilations/app_jitk-linux-debug-x64/multitest_ffi_2_vmspecific_leaf_call_test_02/out.jitsnapshot".

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8846304289428256448/+/u/vm_tests_shard_5/task_stdout_stderr:_vm_tests_shard_5

This is surfacing as an infra failure on the app-kernel-linux-debug-x64 bot, hiding any further status changes.

Test added in 4d50558

We might want to skip the test on the configuration until we figure out what is going on, so that we don't hide further failures under an infra failure.

cc @cskau-g

@dcharkes dcharkes added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening library-ffi labels May 25, 2021
@ghost
Copy link

ghost commented May 25, 2021

This is indeed failing for app_jitk-*-debug-*:

$ tools/test.py --build -n app_jitk-linux-debug-x64 ffi_2/vmspecific_leaf_call_test

--- Command "app_jit" (took 03.000033s):
DART_CONFIGURATION=DebugX64 out/DebugX64/dart --snapshot=/.../out/DebugX64/generated_compilations/app_jitk-linux-debug-x64/multitest_ffi_2_vmspecific_leaf_call_test_02/out.jitsnapshot --snapshot-kind=app-jit [...] /.../out/DebugX64/generated_tests/ffi_2/vmspecific_leaf_call_test_02.dart

exit code:
0

stderr:
Could not find a command named "/.../out/DebugX64/generated_compilations/app_jitk-linux-debug-x64/multitest_ffi_2_vmspecific_leaf_call_test_02/out.jitsnapshot".

The test is expected to crash during runtime, and we set up a special handler to catch this during testing.
Though during app_jit this appears to disrupt the snapshot generation (though the command itself exits with code 0), which means the next run step will fail due to the expected snapshot file missing.

I don't immediately know what we can do about this situation, so for now I suggest we approve ffi{,_2}/vmspecific_leaf_call_test/{02,03} on app_jitk-*-debug-*.

@ghost
Copy link

ghost commented May 25, 2021

201185 adds a Skip for the affected tests.

@ghost ghost closed this as completed May 25, 2021
dart-bot pushed a commit that referenced this issue May 25, 2021
Jobs crash due to missing snapshots, caused by the tests intentionally
crashing.

TEST=-n app_jitk-linux-debug-x64 ffi_2/vmspecific_leaf_call_test

Cq-Include-Trybots: luci.dart.try:app-kernel-linux-debug-x64-try,app-kernel-linux-product-x64-try,app-kernel-linux-release-x64-try
Bug: #46125
Change-Id: Ic62d68e492f6f24cc4ca60151172f89137097398
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201185
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening library-ffi
Projects
None yet
Development

No branches or pull requests

1 participant