Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM Service: Gather virtual memory mappings from other operating systems #46166

Open
rmacnak-google opened this issue May 27, 2021 · 1 comment
Open

VM Service: Gather virtual memory mappings from other operating systems #46166

rmacnak-google opened this issue May 27, 2021 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug vm-service The VM Service Protocol, both the specification and its implementation

Comments

@rmacnak-google
Copy link
Contributor

GetProcessMemoryUsage on Linux/Android now adds virtual memory mappings gather from /proc/self/smaps. Together with the VM's own accounting of its anonymous mappings, this explains nearly all the processes's RSS.

On Fuchsia, we can gather similar information by walking zx_object_get_info(zx_process_self(), ZX_INFO_PROCESS_MAPS).

On Windows, some combination of VirtualQuery, GetMappedFileName, EnumModules should provide similar information.

On Mac, we may need to parse the output of vmmap, though this might be unacceptably slow.
@rmacnak-google rmacnak-google added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug labels May 27, 2021
dart-bot pushed a commit that referenced this issue May 27, 2021
@rmacnak-google
[vm, service] Include mapped files in GetProcessMemoryUsage.
266ad2a 
TEST=ci
Bug: #46166
Change-Id: I66322c70e066bb89c1d568848e17f2ec4f8552d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201444
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
@a-siva
Copy link
Contributor

a-siva commented May 27, 2021

//cc @bkonyi

@rmacnak-google rmacnak-google added vm-service The VM Service Protocol, both the specification and its implementation and removed pkg-vm-service labels Jan 19, 2023
@a-siva a-siva added the P3 A lower priority bug or feature request label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug vm-service The VM Service Protocol, both the specification and its implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmacnak-google @a-siva