Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gardening/test] string_overflow_test is failing #46225

Closed
ghost opened this issue Jun 3, 2021 · 3 comments
Closed

[gardening/test] string_overflow_test is failing #46225

ghost opened this issue Jun 3, 2021 · 3 comments
Assignees
@mkustermann
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-test

Comments

@ghost
Copy link

ghost commented Jun 3, 2021

This failure currently affects a large number of bots:

Unhandled exception:
Out of Memory
#0      _StringBase._concatRangeNative (dart:core-patch/string_patch.dart:956:34)
#1      String._concatAll (dart:core-patch/string_patch.dart:1008:26)
#2      _StringBase._interpolate (dart:core-patch/string_patch.dart:876:27)
#3      main (file:///b/s/w/ir/tests/standalone/string_overflow_test.dart:14:34)
#4      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:283:19)
#5      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

The reason this old test is failing now is that 201227 renamed the file which likely caused it to start getting picked up as a test. Plus the catch for OoM errors was removed.

I'll go ahead and approve this failing to unblock the bots.
Though my personal feeling is that this test probably should be rewritten to at least be less wasteful with memory, if possible.
@ghost ghost added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) gardening type-test labels Jun 3, 2021
@ghost
Copy link
Author

ghost commented Jun 3, 2021

CC: @munificent FYI

@devoncarew devoncarew added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jun 3, 2021
@mkustermann mkustermann self-assigned this Jun 4, 2021
@mkustermann
Copy link
Member

Tests cannot assume they can allocate a large amount of memory. I'll try to fix it.

@munificent
Copy link
Member

Thanks for the fix! I know absolutely nothing about the test. I just happened to be the one who realized that it was never actually being run.

copybara-service bot pushed a commit that referenced this issue Oct 27, 2023
@whesse
Avoid crashes in string concatenation 32-bit integer overflow test
adc79bc 
The test standalone/string_overflow_test.dart is causing crashes
and out-of-memory thrashing on some configurations. It was originally
a regression test that concatenating a string with 2^31 characters
did not overflow a 32-bit signed integer.

It was changed to exponentially grow a string until an out-of-memory
runtime exception is thrown in Dart.  On some VM configurations,
this crashes the machine instead.

Restoring it to only check concatenating a string of 2^31 bytes.

Bug: #46225
Change-Id: Ib50625fe14be2613c907a7bc30cd57766693f6aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332423
Reviewed-by: Martin Kustermann <kustermann@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkustermann mkustermann

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@munificent @devoncarew @mkustermann