Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky vm/dart_2/isolates/fast_object_copy_test turned Timeout on dartk-linux-release-simarm64 #46740

Closed
aam opened this issue Jul 28, 2021 · 4 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@aam
Copy link
Contributor

aam commented Jul 28, 2021

on https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/vm-kernel-linux-release-simarm64/12186/overview

--- Command "vm_compile_to_kernel" (took 01.000433s):
DART_CONFIGURATION=ReleaseSIMARM64 /b/s/w/ir/pkg/vm/tool/gen_kernel --no-aot --platform=out/ReleaseSIMARM64/vm_platform_strong.dill -o /b/s/w/ir/out/ReleaseSIMARM64/generated_compilations/dartk-linux-release-simarm64/runtime_tests_vm_dart_2_isolates_fast_object_copy_test/out.dill /b/s/w/ir/runtime/tests/vm/dart_2/isolates/fast_object_copy_test.dart --packages=/b/s/w/ir/.packages -Ddart.vm.product=false

exit code:
0

--- Command "vm" (took 16:00.000441s):
DART_CONFIGURATION=ReleaseSIMARM64 out/ReleaseSIMARM64/dart --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/out/ReleaseSIMARM64/generated_compilations/dartk-linux-release-simarm64/runtime_tests_vm_dart_2_isolates_fast_object_copy_test/out.dill

exit code:
null

diagnostics:
Process list including children: [19687]
Trying to capture stack trace for pid 19687
PID 19687 - process
TID 19687:
#0  0x00007f8861193ad3 pthread_cond_wait@@GLIBC_2.3.2
#1  0x0000564f28b29f68 dart::Monitor::WaitMicros(long)
#2  0x0000564f28fb6dca Dart_RunLoop
#3  0x0000564f288abe59 dart::bin::RunMainIsolate(char const*, char const*, dart::bin::CommandLineOptions*)
#4  0x0000564f288acbb7 dart::bin::main(int, char**)
#5  0x0000564f288ad989 main
#6  0x00007f8860a18bf7 __libc_start_main
#7  0x0000564f288a64e9 _start
TID 19688:
#0  0x00007f8860b18a47 epoll_wait
#1  0x0000564f288bc598 dart::bin::EventHandlerImplementation::Poll(unsigned long)
#2  0x0000564f289ee090 dart::bin::ThreadStart(void*)
#3  0x00007f886118d6db start_thread
#4  0x00007f8860b1871f __clone
TID 19689:
#0  0x00007f8861193ad3 pthread_cond_wait@@GLIBC_2.3.2
#1  0x0000564f28b29f68 dart::Monitor::WaitMicros(long)
#2  0x0000564f28bd9150 dart::BackgroundCompiler::Run()
#3  0x0000564f28bc66b8 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*)
#4  0x0000564f28bc6aec dart::ThreadPool::Worker::Main(unsigned long)
#5  0x0000564f28b29818 dart::ThreadStart(void*)
#6  0x00007f886118d6db start_thread
#7  0x00007f8860b1871f __clone
TID 19694:
#0  0x0000564f28ba6d31 dart::Simulator::DecodeLoadStore(dart::Instr*)
#1  0x0000564f28ba3523 dart::Simulator::InstructionDecode(dart::Instr*)
#2  0x0000564f28baa74b dart::Simulator::Execute()
#3  0x0000564f28baab04 dart::Simulator::Call(long, long, long, long, long, bool, bool)
#4  0x0000564f28a4ac2c dart::DartEntry::InvokeCode(dart::Code const&, unsigned long, dart::Array const&, dart::Array const&, dart::Thread*)
#5  0x0000564f28a4aa6d dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&, unsigned long)
#6  0x0000564f28a4d06d dart::DartLibraryCalls::HandleMessage(dart::Object const&, dart::Instance const&)
#7  0x0000564f28a75611 dart::IsolateMessageHandler::HandleMessage(std::__2::unique_ptr<dart::Message, std::__2::default_delete<dart::Message> >)
#8  0x0000564f28aa001c dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool)
#9  0x0000564f28aa073f dart::MessageHandler::TaskCallback()
#10 0x0000564f28bc66b8 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*)
#11 0x0000564f28bc6aec dart::ThreadPool::Worker::Main(unsigned long)
#12 0x0000564f28b29818 dart::ThreadStart(void*)
#13 0x00007f886118d6db start_thread
#14 0x00007f8860b1871f __clone



stdout:
testTransferrable
testTransferrable2
testTransferrable3
testTransferrable4
testTransferrable5
testExternalTypedData
testExternalTypedData2
testExternalTypedData3
testExternalTypedData4
testExternalTypedData5
testExternalTypedData6
testInternalTypedDataView
testInternalTypedDataView2
testInternalTypedDataView3
testInternalTypedDataView4
testExternalTypedDataView
testExternalTypedDataView2
testExternalTypedDataView3
testExternalTypedDataView4
testArray
testMapRehash
testMapRehash2
testMapRehash3
testSetRehash
testSetRehash2
testSetRehash3
testFastOnly
testSlowOnly

--- Re-run this test:
python3 tools/test.py -n dartk-linux-release-simarm64 vm/dart_2/isolates/fast_object_copy_test/0
@aam aam added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Jul 28, 2021
@aam aam changed the title vm/dart_2/isolates/fast_object_copy_test turned flaky on dartk-linux-release-simarm64 flaky vm/dart_2/isolates/fast_object_copy_test turned Timeout on dartk-linux-release-simarm64 Jul 28, 2021
@whesse
Copy link
Contributor

whesse commented Mar 15, 2022

On simarm64, isolates/fast_object_copy_test times out after 15 minutes, but isolates/fast_object_copy2_test passes in 5 seconds.

Because it is very consistently timing out on the jit simarm64 platforms, I think it should be skipped on those platforms. There have been occasional timeouts on simarm, but not consistently.

Even on simarm, the fast_object_copy_test is taking 11 minutes for each variation, and the fast_object_copy2_test is only taking 3 seconds. So skipping the test on simarm would also save a lot of builder time, even though it is not timing out.

Skip CL: https://dart-review.googlesource.com/c/sdk/+/237320

I suspect the long runtime is due to a few loops that send 20 MB typed data between isolates, and they each run 10 times. Maybe 10 times is not needed.
expensive loop

@dcharkes
Copy link
Contributor

Thanks @whesse !

copybara-service bot pushed a commit that referenced this issue Mar 15, 2022
…ctures

Bug: #46740
Change-Id: I5a6a7d72fea080c04d90a3aa6e5af2e02f7c3644
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237320
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Development

No branches or pull requests

4 participants